-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligned lerna
and nx
versions
#18121
Conversation
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/lerna@7.1.3, npm/lerna@7.1.4, npm/nx@16.3.2 |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat's wrong with native code?Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs. Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings. What is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
b66a233
to
42f7d6c
Compare
Socket security reported that |
Points to see
chia-blockchain-gui
'smain
lerna
version to8.1.3
,nx
version to19.0.1
forbuild_scripts/npm_{linux,macos,windows}
npm audit fix
tobuild_scripts/npm_{linux,windows}
since it reported vuln dependencies..nx/cache
to.gitignore
since it shouldn't be managed in version system.The task to doDoneI ran
npm i
in my m1 Mac inbuild_scripts/npm_{linux,windows}
but this seems to installbuild_scripts/npm_{linux,windows}/node_modules/@nx/nx-darwin-arm64
for macOS.I need to run
npm i
on Windows for.../npm_windows
and Linux(like Ubuntu) for.../npm_linux
.