Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned lerna and nx versions #18121

Merged
merged 6 commits into from
Jun 8, 2024
Merged

Aligned lerna and nx versions #18121

merged 6 commits into from
Jun 8, 2024

Conversation

ChiaMineJP
Copy link
Contributor

@ChiaMineJP ChiaMineJP commented Jun 6, 2024

Points to see

  • This PR updates the GUI submodule ref to the latest chia-blockchain-gui's main
  • Updated lerna version to 8.1.3, nx version to 19.0.1 for build_scripts/npm_{linux,macos,windows}
  • Applied npm audit fix to build_scripts/npm_{linux,windows} since it reported vuln dependencies.
  • Added .nx/cache to .gitignore since it shouldn't be managed in version system.

The task to do Done

I ran npm i in my m1 Mac in build_scripts/npm_{linux,windows} but this seems to install build_scripts/npm_{linux,windows}/node_modules/@nx/nx-darwin-arm64 for macOS.
I need to run npm i on Windows for .../npm_windows and Linux(like Ubuntu) for .../npm_linux.

@ChiaMineJP ChiaMineJP added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Jun 6, 2024
@ChiaMineJP ChiaMineJP self-assigned this Jun 6, 2024
@ChiaMineJP ChiaMineJP requested a review from a team as a code owner June 6, 2024 01:54
Copy link

socket-security bot commented Jun 6, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/nx@19.0.1 environment, filesystem, network, shell, unsafe Transitive: eval +132 95.6 MB nrwl-jason

🚮 Removed packages: npm/lerna@7.1.3, npm/lerna@7.1.4, npm/nx@16.3.2

View full report↗︎

Copy link

socket-security bot commented Jun 6, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Native code npm/@parcel/watcher@2.0.4
Install scripts npm/nx@16.3.2
  • Install script: postinstall
  • Source: node ./bin/compute-project-graph

View full report↗︎

Next steps

What's wrong with native code?

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Ensure that native code bindings are expected. Consumers may consider pure JS and functionally similar alternatives to avoid the challenges and risks associated with native code bindings.

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@parcel/watcher@2.0.4
  • @SocketSecurity ignore npm/nx@16.3.2

@ChiaMineJP ChiaMineJP marked this pull request as draft June 6, 2024 02:02
@ChiaMineJP ChiaMineJP changed the base branch from main to use_root June 6, 2024 13:47
@ChiaMineJP ChiaMineJP changed the base branch from use_root to main June 6, 2024 13:49
@ChiaMineJP
Copy link
Contributor Author

ChiaMineJP commented Jun 6, 2024

Socket security reported that nx@16.3.2 and @parcel/watcher@2.0.4 are risky but I couldn't find them in any package-lock.json.
Note: nx@16.3.2 was replaced by nx@19.0.1 with this PR.
Maybe socket security saw the old snapshot for some reason.
I think these alerts can be ignored.

@ChiaMineJP ChiaMineJP marked this pull request as ready for review June 6, 2024 15:01
markelrod
markelrod previously approved these changes Jun 6, 2024
@ChiaMineJP ChiaMineJP changed the base branch from main to release/2.4.0 June 7, 2024 13:38
@ChiaMineJP ChiaMineJP dismissed markelrod’s stale review June 7, 2024 13:38

The base branch was changed.

@ChiaMineJP ChiaMineJP requested a review from markelrod June 7, 2024 13:38
@cmmarslender cmmarslender merged commit 1e67783 into release/2.4.0 Jun 8, 2024
358 of 359 checks passed
@cmmarslender cmmarslender deleted the cmj.bump-lerna branch June 8, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants