Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update long-reorg tests along with the reorg test chains #18517

Merged
merged 1 commit into from
Sep 3, 2024
Merged

update long-reorg tests along with the reorg test chains #18517

merged 1 commit into from
Sep 3, 2024

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Aug 23, 2024 •
edited
Loading

Purpose:

Increase test coverage by making the fork point be > 0

Current Behavior:

The long reorg tests all reorg to height 0

New Behavior:

Some long reorg tests reorg to height 0 and some to height 1500, thus exercising Almogs recent warm-up code.

@arvidn arvidn requested a review from almogdepaz August 23, 2024 10:26
@arvidn arvidn added the Changed Required label for PR that categorizes merge commit message as "Changed" for changelog label Aug 23, 2024
almogdepaz
almogdepaz previously approved these changes Aug 23, 2024
View reviewed changes
@arvidn arvidn marked this pull request as ready for review August 25, 2024 00:44
@arvidn arvidn requested review from a team as code owners August 25, 2024 00:44
Base automatically changed from fix_long_sync_cache to main August 26, 2024 12:48
@pmaslana pmaslana dismissed almogdepaz’s stale review August 26, 2024 12:48

The base branch was changed.

@arvidn arvidn requested a review from almogdepaz August 26, 2024 17:27
@arvidn arvidn requested a review from wjblanke August 27, 2024 09:26
wjblanke
wjblanke approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@arvidn arvidn added the ready_to_merge Submitter and reviewers think this is ready label Aug 27, 2024
@pmaslana pmaslana merged commit ab8ea7e into main Sep 3, 2024
374 checks passed
@pmaslana pmaslana deleted the update-long-reorg-tests branch September 3, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@cmmarslender cmmarslender cmmarslender approved these changes

@almogdepaz almogdepaz almogdepaz approved these changes

Assignees
No one assigned
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog ready_to_merge Submitter and reviewers think this is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arvidn @wjblanke @cmmarslender @almogdepaz @pmaslana