WhenMainnet #2011
Merged
WhenMainnet #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano54
previously approved these changes
Apr 18, 2021
| @@ -820,6 +820,7 @@ def validate_unfinished_header_block( | |||
| prev_transaction_b = blocks.block_record(header_block.foliage_transaction_block.prev_transaction_block_hash) | |||
| assert prev_transaction_b.timestamp is not None | |||
| if header_block.foliage_transaction_block.timestamp <= prev_transaction_b.timestamp: | |||
| breakpoint() | |||
There was a problem hiding this comment.
yup, thanks for cathcing this
| freeze_period = self.service.constants.INITIAL_FREEZE_PERIOD | ||
| return {"INITIAL_FREEZE_PERIOD": freeze_period} | ||
| freeze_period = self.service.constants.INITIAL_FREEZE_END_TIMESTAMP | ||
| return {"INITIAL_FREEZE_END_TIMESTAMP": freeze_period} |
There was a problem hiding this comment.
@seeden needs to support this since warning is based on FREEZE_PERIOD
There was a problem hiding this comment.
It does't look like it's used in main at the moment
| freeze_period = self.service.constants.INITIAL_FREEZE_PERIOD | ||
| return {"INITIAL_FREEZE_PERIOD": freeze_period} | ||
| freeze_period = self.service.constants.INITIAL_FREEZE_END_TIMESTAMP | ||
| return {"INITIAL_FREEZE_END_TIMESTAMP": freeze_period} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.