brake if end of ses list #3583

almogdepaz · 2021-05-03T21:55:50Z

throw and keep in sync if weight proof peak is not heavier then current peak we know
this can happen if we batch sync while request is pending

aqk · 2021-05-03T22:44:52Z

chia/full_node/full_node.py

+            # dont sync to wp if local peak is heavier,
+            # dont ban peer, we asked for this peak
+            if response.wp.recent_chain_data[-1].reward_chain_block.weight <= self.blockchain.get_peak().weight:
+                raise RuntimeError(f"current peak is heavier than Weight proof peek: {weight_proof_peer.peer_host}")


Does this throw only interrupt the WP validation process / thread, not the main networking thread?

this is on the main thread before we start the validation

aqk · 2021-05-03T22:48:41Z

chia/full_node/weight_proof.py

@@ -618,6 +618,9 @@ def get_fork_point(self, received_summaries: List[SubEpochSummary]) -> uint32:
        for idx, summary_height in enumerate(ses_heights):
            log.debug(f"check summary {idx} height {summary_height}")
            local_ses = self.blockchain.get_ses(summary_height)
+            if idx == len(received_summaries) - 1:


Could add assert len(received_summaries) > 0 at the start of get_fork_point

thats always the case or we would have failed validation before this method.
do you think it will be more readable that way?

No, I'm happy with your judgement.

I just always want to point out any issue I can think of, and I don't know enough about this part yet to know if len == 0 is possible.

arvidn · 2021-05-03T23:18:32Z

chia/full_node/weight_proof.py

@@ -618,6 +618,9 @@ def get_fork_point(self, received_summaries: List[SubEpochSummary]) -> uint32:
        for idx, summary_height in enumerate(ses_heights):
            log.debug(f"check summary {idx} height {summary_height}")
            local_ses = self.blockchain.get_ses(summary_height)
+            if idx == len(received_summaries) - 1:
+                # break if end of wp summaries


a bit of a nit, but this comment seems pretty pointless. I think it would be better to have a comment explaining why we're done with the loop in this case

niting is good, updated

wjblanke

aok

@Chida82

* 2 harvesting features (#3331) * 3 harvesting features: - Debug level shows the time for every quality lookup - Warning level if takes longer than 5 seconds - Allow configuration of plot loading interval (default 2 minutes) * Comment out super logging * Improve wallet consistency (#3305) * Improve wallet consistency * Improve CLI significantly, and fix self-tx balances * Fix await * Fix deadlock and test * Remove spam.sh * Changelog for 1.1.3 (#3345) * Changelog for 1.1.3 * minor updates * updates part 3 * Those engineers who don't update changelogs... :) * Apologies to @Chida82 who added log rotate count! (#3369) * Rust parse serialized (#3444) * use rust implementation for finding length of a serialized clvm program * bump clvm_rs version * Don't retry respond_peers message (#3508) * don't increment counters for outgoing messages blocked by the rate limit. (#3518) This was causing a problem where outbound messages, blocked by the rate limiter, would still increment the counters as-if they had been sent. This, in turn, could cause other message types to get blocked becuase the rate limiter thought we had sent a lot of the other (blocked) message type. * hide secret wallet key by default with 'chia keys show' (#3565) Co-authored-by: Adam Kelly <aqk@aqk.im> * brake if end of ses list (#3583) * brake if end of ses list * log * throw if wp peak is not heavier * comment * handle sync from scratch * comment Co-authored-by: Mariano Sorgente <3069354+mariano54@users.noreply.github.com> Co-authored-by: Gene Hoffman <30377676+hoffmang9@users.noreply.github.com> Co-authored-by: Arvid Norberg <arvid@libtorrent.org> Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com> Co-authored-by: Adam Kelly <aqk@aqk.im> Co-authored-by: Almog De Paz <almogdepaz@gmail.com>

@Chida82

* 2 harvesting features (#3331) * 3 harvesting features: - Debug level shows the time for every quality lookup - Warning level if takes longer than 5 seconds - Allow configuration of plot loading interval (default 2 minutes) * Comment out super logging * Improve wallet consistency (#3305) * Improve wallet consistency * Improve CLI significantly, and fix self-tx balances * Fix await * Fix deadlock and test * Remove spam.sh * Changelog for 1.1.3 (#3345) * Changelog for 1.1.3 * minor updates * updates part 3 * Those engineers who don't update changelogs... :) * Apologies to @Chida82 who added log rotate count! (#3369) * Rust parse serialized (#3444) * use rust implementation for finding length of a serialized clvm program * bump clvm_rs version * Don't retry respond_peers message (#3508) * don't increment counters for outgoing messages blocked by the rate limit. (#3518) This was causing a problem where outbound messages, blocked by the rate limiter, would still increment the counters as-if they had been sent. This, in turn, could cause other message types to get blocked becuase the rate limiter thought we had sent a lot of the other (blocked) message type. * hide secret wallet key by default with 'chia keys show' (#3565) Co-authored-by: Adam Kelly <aqk@aqk.im> * brake if end of ses list (#3583) * brake if end of ses list * log * throw if wp peak is not heavier * comment * handle sync from scratch * comment * fix indentation issue in message send retry logic. factor out retry coroutine (#3629) * Fix test (#3350) * Mempool sorting and accept reverted pending transactions (#3683) * Sort by fee/cost, and fix pending tx issue in reorgs * Fix test name * Bring the seen list size back to normal. Co-authored-by: Mariano Sorgente <3069354+mariano54@users.noreply.github.com> Co-authored-by: Gene Hoffman <30377676+hoffmang9@users.noreply.github.com> Co-authored-by: Arvid Norberg <arvid@libtorrent.org> Co-authored-by: Adam Kelly <338792+aqk@users.noreply.github.com> Co-authored-by: Adam Kelly <aqk@aqk.im> Co-authored-by: Almog De Paz <almogdepaz@gmail.com>

almogdepaz added 4 commits May 4, 2021 00:53

brake if end of ses list

78738b3

log

9389888

throw if wp peak is not heavier

fbea33b

comment

78d4a9d

aqk reviewed May 3, 2021

View reviewed changes

handle sync from scratch

4edd55e

arvidn reviewed May 3, 2021

View reviewed changes

comment

de79e56

wjblanke approved these changes May 4, 2021

View reviewed changes

wjblanke merged commit 859a080 into main May 4, 2021

wjblanke deleted the wp_fork_is_lower_height branch May 4, 2021 01:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

brake if end of ses list #3583

brake if end of ses list #3583

almogdepaz commented May 3, 2021 •

edited

Loading

aqk May 3, 2021

almogdepaz May 3, 2021 •

edited

Loading

aqk May 3, 2021

almogdepaz May 3, 2021 •

edited

Loading

aqk May 3, 2021

arvidn May 3, 2021

almogdepaz May 3, 2021 •

edited

Loading

wjblanke left a comment

brake if end of ses list #3583

brake if end of ses list #3583

Conversation

almogdepaz commented May 3, 2021 • edited Loading

aqk May 3, 2021

Choose a reason for hiding this comment

almogdepaz May 3, 2021 • edited Loading

Choose a reason for hiding this comment

aqk May 3, 2021

Choose a reason for hiding this comment

almogdepaz May 3, 2021 • edited Loading

Choose a reason for hiding this comment

aqk May 3, 2021

Choose a reason for hiding this comment

arvidn May 3, 2021

Choose a reason for hiding this comment

almogdepaz May 3, 2021 • edited Loading

Choose a reason for hiding this comment

wjblanke left a comment

Choose a reason for hiding this comment

almogdepaz commented May 3, 2021 •

edited

Loading

almogdepaz May 3, 2021 •

edited

Loading

almogdepaz May 3, 2021 •

edited

Loading

almogdepaz May 3, 2021 •

edited

Loading