CHIA-1169: Serde support for common types #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rigidity
changed the title
Rigidity
commented
Aug 17, 2024
| #[derive(Default, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] | ||
| #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))] | ||
| pub struct Bytes(Vec<u8>); | ||
|
|
||
| #[cfg(feature = "serde")] |
There was a problem hiding this comment.
I'm not a fan of duplicating the definition of Bytes and BytesImpl. It might be better to get rid of serde_with entirely and just use the manual implementation like I did for PublicKey
| @@ -49,6 +49,7 @@ cast_possible_wrap = "allow" | |||
| cast_lossless = "allow" | |||
| similar_names = "allow" | |||
| implicit_hasher = "allow" | |||
| unsafe_derive_deserialize = "allow" | |||
There was a problem hiding this comment.
Not sure why it was giving this warning when deriving on types like Coin. Maybe the Python bindings are tripping it up
Pull Request Test Coverage Report for Build 10429084212Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.