Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exceptions in the Cities log #311

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Fix exceptions in the Cities log #311

merged 1 commit into from
Apr 11, 2023

Conversation

kaenganxt
Copy link
Member

@kaenganxt kaenganxt commented Apr 11, 2023

  • Use customized, stripped down version of protobuf-net which has no further assembly dependencies
  • Only put correct dlls to output directory so we can use the whole directory for an installation
  • Fix exception about our save file by adding an empty package pathpath
  • Correctly cancel the rich presence thread
  • Shutdown our own Steam integration when Cities shuts down to prevent crashes
  • Check for the existence of the simulation manager when shutting down the game as client
  • Simplify the call to OpenNAT

This should resolve all exceptions in the Cities log which where caused by us.

Contributes to #289

- Use customized, stripped down version of protobuf-net which has no further assembly dependencies
- Only put correct dlls to output directory so we can use the whole directory for an installation
- Fix exception about our save file by adding an empty package pathpath
- Correctly cancel the rich presence thread
- Shutdown our own Steam integration when Cities shuts down to prevent crashes
- Check for the existence of the simulation manager when shutting down the game as client
- Simplify the call to OpenNAT
@kaenganxt kaenganxt merged commit 29272d3 into master Apr 11, 2023
@kaenganxt kaenganxt deleted the fix-exceptions branch April 11, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants