Skip to content
This repository has been archived by the owner on Dec 2, 2022. It is now read-only.

Commit

Permalink
fix(*-typescript): [eslint v6] overrides
Browse files Browse the repository at this point in the history
  • Loading branch information
buschtoens committed Jun 26, 2019
1 parent 12e6b82 commit c78e656
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
14 changes: 13 additions & 1 deletion packages/eslint-config-ember-typescript/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
'use strict';

module.exports = {
extends: ['@clark/ember', '@clark/typescript']
extends: ['@clark/ember', '@clark/typescript'],

/**
* Since the order of application is `ember` and _then_ `typescript`, rules
* set in `typescript`, override overrides in `ember`. While we in general
* want any regular rules in `typescript` to override any regular rules in
* `ember`, we want the overrides in `ember` to take effect.
*
* To achieve this, we include the overrides again.
*
* @see https://eslint.org/docs/user-guide/migrating-to-6.0.0#-overrides-in-an-extended-config-file-can-now-be-overridden-by-a-parent-config-file
*/
overrides: require('@clark/eslint-config-ember').overrides
};
14 changes: 13 additions & 1 deletion packages/eslint-config-node-typescript/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,17 @@ module.exports = {
rules: {
'node/no-unsupported-features/es-builtins': 'off',
'node/no-unsupported-features/es-syntax': 'off'
}
},

/**
* Since the order of application is `node` and _then_ `typescript`, rules
* set in `typescript`, override overrides in `node`. While we in general
* want any regular rules in `typescript` to override any regular rules in
* `node`, we want the overrides in `node` to take effect.
*
* To achieve this, we include the overrides again.
*
* @see https://eslint.org/docs/user-guide/migrating-to-6.0.0#-overrides-in-an-extended-config-file-can-now-be-overridden-by-a-parent-config-file
*/
overrides: require('@clark/eslint-config-node').overrides
};

0 comments on commit c78e656

Please sign in to comment.