Skip to content

Commit

Permalink
Removed obsolete TSRMLS_* usage. (protocolbuffers#7731)
Browse files Browse the repository at this point in the history
  • Loading branch information
haberman authored and acozzette committed Aug 7, 2020
1 parent 5f32d48 commit a28af65
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 18 deletions.
2 changes: 1 addition & 1 deletion php/ext/google/protobuf/array.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ static void RepeatedField_destructor(zend_object* obj) {
zend_object_std_dtor(&intern->std);
}

static HashTable *RepeatedField_GetProperties(zval *object TSRMLS_DC) {
static HashTable *RepeatedField_GetProperties(zval *object) {
return NULL; // We do not have a properties table.
}

Expand Down
24 changes: 10 additions & 14 deletions php/ext/google/protobuf/def.c
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,7 @@ PHP_METHOD(EnumDescriptor, getValue) {
zend_long index;
zval ret;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &index) ==
FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "l", &index) == FAILURE) {
zend_error(E_USER_ERROR, "Expect integer for index.\n");
return;
}
Expand Down Expand Up @@ -284,8 +283,7 @@ PHP_METHOD(OneofDescriptor, getField) {
zend_long index;
zval ret;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &index) ==
FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "l", &index) == FAILURE) {
zend_error(E_USER_ERROR, "Expect integer for index.\n");
return;
}
Expand Down Expand Up @@ -615,8 +613,7 @@ PHP_METHOD(Descriptor, getField) {
zval ret;
zend_long index;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &index) ==
FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "l", &index) == FAILURE) {
zend_error(E_USER_ERROR, "Expect integer for index.\n");
return;
}
Expand Down Expand Up @@ -658,8 +655,7 @@ PHP_METHOD(Descriptor, getOneofDecl) {
zend_long index;
zval ret;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "l", &index) ==
FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "l", &index) == FAILURE) {
zend_error(E_USER_ERROR, "Expect integer for index.\n");
return;
}
Expand Down Expand Up @@ -799,8 +795,8 @@ PHP_METHOD(DescriptorPool, getDescriptorByClassName) {
zend_string *str;
zval ret;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &classname,
&classname_len) == FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "s", &classname, &classname_len) ==
FAILURE) {
return;
}

Expand Down Expand Up @@ -828,8 +824,8 @@ PHP_METHOD(DescriptorPool, getEnumDescriptorByClassName) {
zend_string *str;
zval ret;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &classname,
&classname_len) == FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "s", &classname, &classname_len) ==
FAILURE) {
return;
}

Expand All @@ -856,8 +852,8 @@ PHP_METHOD(DescriptorPool, getDescriptorByProtoName) {
zend_long protoname_len;
const upb_msgdef *m;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "s", &protoname,
&protoname_len) == FAILURE) {
if (zend_parse_parameters(ZEND_NUM_ARGS(), "s", &protoname, &protoname_len) ==
FAILURE) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion php/ext/google/protobuf/map.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ static zval *Map_GetPropertyPtrPtr(zval *object, zval *member, int type,
return NULL; // We don't offer direct references to our properties.
}

static HashTable *map_get_properties(zval *object TSRMLS_DC) {
static HashTable *map_get_properties(zval *object) {
return NULL; // We do not have a properties table.
}

Expand Down
4 changes: 2 additions & 2 deletions php/ext/google/protobuf/message.c
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ static zval *Message_get_property_ptr_ptr(zval *object, zval *member, int type,
* Object handler for the get_properties event in PHP. This returns a HashTable
* of our internal properties. We don't support this, so we return NULL.
*/
static HashTable* Message_get_properties(zval* object TSRMLS_DC) {
static HashTable *Message_get_properties(zval *object) {
return NULL; // We don't offer direct references to our properties.
}

Expand Down Expand Up @@ -619,7 +619,7 @@ PHP_METHOD(Message, serializeToJsonString) {
zend_bool preserve_proto_fieldnames = false;
upb_status status;

if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "|b",
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|b",
&preserve_proto_fieldnames) == FAILURE) {
return;
}
Expand Down

0 comments on commit a28af65

Please sign in to comment.