feat(rowbinary): better panics

ClickHouse · Aug 18, 2024 · 3c6a6a9 · 3c6a6a9
1 parent fab3dbd
commit 3c6a6a9
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 29 deletions.
diff --git a/src/rowbinary/de.rs b/src/rowbinary/de.rs
@@ -115,7 +115,7 @@ impl<'de, 'a, B: Buf> Deserializer<'de> for &'a mut RowBinaryDeserializer<'de, B
 
     #[inline]
     fn deserialize_char<V: Visitor<'de>>(self, _: V) -> Result<V::Value> {
-        todo!();
+        panic!("character types are unsupported: `char`");
     }
 
     #[inline]
@@ -160,11 +160,11 @@ impl<'de, 'a, B: Buf> Deserializer<'de> for &'a mut RowBinaryDeserializer<'de, B
     #[inline]
     fn deserialize_enum<V: Visitor<'de>>(
         self,
-        _enum: &'static str,
+        name: &'static str,
         _variants: &'static [&'static str],
         _visitor: V,
     ) -> Result<V::Value> {
-        todo!();
+        panic!("enums are unsupported: `{name}`");
     }
 
     #[inline]
@@ -220,7 +220,7 @@ impl<'de, 'a, B: Buf> Deserializer<'de> for &'a mut RowBinaryDeserializer<'de, B
 
     #[inline]
     fn deserialize_map<V: Visitor<'de>>(self, _visitor: V) -> Result<V::Value> {
-        todo!();
+        panic!("maps are unsupported, use `Vec<(A, B)>` instead");
     }
 
     #[inline]
@@ -235,7 +235,7 @@ impl<'de, 'a, B: Buf> Deserializer<'de> for &'a mut RowBinaryDeserializer<'de, B
 
     #[inline]
     fn deserialize_identifier<V: Visitor<'de>>(self, _visitor: V) -> Result<V::Value> {
-        todo!();
+        panic!("identifiers are unsupported");
     }
 
     #[inline]
@@ -250,25 +250,25 @@ impl<'de, 'a, B: Buf> Deserializer<'de> for &'a mut RowBinaryDeserializer<'de, B
     #[inline]
     fn deserialize_unit_struct<V: Visitor<'de>>(
         self,
-        _name: &'static str,
+        name: &'static str,
         _visitor: V,
     ) -> Result<V::Value> {
-        todo!();
+        panic!("unit types are unsupported: `{name}`");
     }
 
     #[inline]
     fn deserialize_tuple_struct<V: Visitor<'de>>(
         self,
-        _name: &'static str,
+        name: &'static str,
         _len: usize,
         _visitor: V,
     ) -> Result<V::Value> {
-        todo!();
+        panic!("tuple struct types are unsupported: `{name}`");
     }
 
     #[inline]
     fn deserialize_ignored_any<V: Visitor<'de>>(self, _visitor: V) -> Result<V::Value> {
-        todo!();
+        panic!("ignored types are unsupported");
     }
 
     #[inline]

diff --git a/src/rowbinary/ser.rs b/src/rowbinary/ser.rs
@@ -73,7 +73,7 @@ impl<'a, B: BufMut> Serializer for &'a mut RowBinarySerializer<B> {
 
     #[inline]
     fn serialize_char(self, _v: char) -> Result<()> {
-        todo!();
+        panic!("character types are unsupported: `char`");
     }
 
     #[inline]
@@ -104,22 +104,22 @@ impl<'a, B: BufMut> Serializer for &'a mut RowBinarySerializer<B> {
 
     #[inline]
     fn serialize_unit(self) -> Result<()> {
-        todo!();
+        panic!("unit types are unsupported: `()`");
     }
 
     #[inline]
-    fn serialize_unit_struct(self, _name: &'static str) -> Result<()> {
-        todo!();
+    fn serialize_unit_struct(self, name: &'static str) -> Result<()> {
+        panic!("unit types are unsupported: `{name}`");
     }
 
     #[inline]
     fn serialize_unit_variant(
         self,
-        _name: &'static str,
+        name: &'static str,
         _variant_index: u32,
-        _variant: &'static str,
+        variant: &'static str,
     ) -> Result<()> {
-        todo!();
+        panic!("unit variant types are unsupported: `{name}::{variant}`");
     }
 
     #[inline]
@@ -134,12 +134,12 @@ impl<'a, B: BufMut> Serializer for &'a mut RowBinarySerializer<B> {
     #[inline]
     fn serialize_newtype_variant<T: Serialize + ?Sized>(
         self,
-        _name: &'static str,
+        name: &'static str,
         _variant_index: u32,
-        _variant: &'static str,
+        variant: &'static str,
         _value: &T,
     ) -> Result<()> {
-        todo!();
+        panic!("newtype variant types are unsupported: `{name}::{variant}`");
     }
 
     #[inline]
@@ -157,26 +157,26 @@ impl<'a, B: BufMut> Serializer for &'a mut RowBinarySerializer<B> {
     #[inline]
     fn serialize_tuple_struct(
         self,
-        _name: &'static str,
+        name: &'static str,
         _len: usize,
     ) -> Result<Self::SerializeTupleStruct> {
-        todo!();
+        panic!("tuple struct types are unsupported: `{name}`");
     }
 
     #[inline]
     fn serialize_tuple_variant(
         self,
-        _name: &'static str,
+        name: &'static str,
         _variant_index: u32,
-        _variant: &'static str,
+        variant: &'static str,
         _len: usize,
     ) -> Result<Self::SerializeTupleVariant> {
-        todo!();
+        panic!("tuple variant types are unsupported: `{name}::{variant}`");
     }
 
     #[inline]
     fn serialize_map(self, _len: Option<usize>) -> Result<Self::SerializeMap> {
-        todo!();
+        panic!("maps are unsupported, use `Vec<(A, B)>` instead");
     }
 
     #[inline]
@@ -187,12 +187,12 @@ impl<'a, B: BufMut> Serializer for &'a mut RowBinarySerializer<B> {
     #[inline]
     fn serialize_struct_variant(
         self,
-        _name: &'static str,
+        name: &'static str,
         _variant_index: u32,
-        _variant: &'static str,
+        variant: &'static str,
         _len: usize,
     ) -> Result<Self::SerializeStructVariant> {
-        todo!();
+        panic!("struct variant types are unsupported: `{name}::{variant}`");
     }
 
     #[inline]