Add query/insert level settings override #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
commented
Aug 2, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
loyd
reviewed
Aug 4, 2024
slvrtrn
changed the title
loyd
reviewed
Aug 7, 2024
Closed
loyd
reviewed
Aug 7, 2024
| Err(Error::TimedOut) | ||
| } | ||
| }; | ||
| self.state = InsertState::Completed; |
There was a problem hiding this comment.
If panic happens, this isn't executed. In general, it should never happen, although.
loyd
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Query::with_option(...)Insert::with_option(...)Inserter::with_option(...)These methods behave similarly to the
Client::with_optionbut allow overriding settings for a particular query/statement only.For
Insert, some internal refactoring was required to postpone creating the outgoing request.Additionally, fixed some stale links in the code comments.