chore: Let AWS Image Builder and ECR deal with deleting old images fo…

…r us (#476)

AWS Image Builder [recently introduced lifecycle rules](https://aws.amazon.com/about-aws/whats-new/2023/11/ec2-image-builder-lifecycle-management-deletion/) that can help us remove old images from EC2/ECR, and their descriptors on AWS Image Builder side.

CDK [added automatic deletion of images in repositories](aws/aws-cdk#24572) so they can be deleted in CloudFormation easily. We had a custom resource to delete images, but now we can just use `autoDeleteImages`.

We still have to clean-up AWS Image Builder image descriptors and AMIs with a custom resource. We do this so removing our construct won't leave anything behind.

Resolves #471

BREAKING CHANGE: CDK 2.110.0 and above is required

.projenrc.js

@@ -7,7 +7,7 @@ const project = new awscdk.AwsCdkConstructLibrary({
   author: 'Amir Szekely',
   authorAddress: 'amir@cloudsnorkel.com',
   stability: Stability.EXPERIMENTAL,
-  cdkVersion: '2.77.0', // 2.21.1 for lambda url, 2.29.0 for Names.uniqueResourceName(), 2.50.0 for JsonPath.base64Encode, 2.77.0 for node 16
+  cdkVersion: '2.110.0', // 2.21.1 for lambda url, 2.29.0 for Names.uniqueResourceName(), 2.50.0 for JsonPath.base64Encode, 2.77.0 for node 16, 2.110.0 for ib lifecycle
   defaultReleaseBranch: 'main',
   name: '@cloudsnorkel/cdk-github-runners',
   repositoryUrl: 'https://github.com/CloudSnorkel/cdk-github-runners.git',

src/image-builders/aws-image-builder/ami.ts

@@ -39,18 +39,24 @@ interface AmiRecipeProperties {
 export class AmiRecipe extends ImageBuilderObjectBase {
   public readonly arn: string;
   public readonly name: string;
+  public readonly version: string;
 
   constructor(scope: Construct, id: string, props: AmiRecipeProperties) {
     super(scope, id);
 
-    const name = uniqueImageBuilderName(this);
-
     let components = props.components.map(component => {
       return {
         componentArn: component.arn,
       };
     });
 
+    this.name = uniqueImageBuilderName(this);
+    this.version = this.generateVersion('ImageRecipe', this.name, {
+      platform: props.platform,
+      components,
+      parentAmi: props.baseAmi,
+    });
+
     let workingDirectory;
     if (props.platform == 'Linux') {
       workingDirectory = '/home/runner';
@@ -61,19 +67,14 @@ export class AmiRecipe extends ImageBuilderObjectBase {
     }
 
     const recipe = new imagebuilder.CfnImageRecipe(this, 'Recipe', {
-      name: name,
-      version: this.version('ImageRecipe', name, {
-        platform: props.platform,
-        components,
-        parentAmi: props.baseAmi,
-      }),
+      name: this.name,
+      version: this.version,
       parentImage: props.baseAmi,
       components,
       workingDirectory,
     });
 
     this.arn = recipe.attrArn;
-    this.name = name;
   }
 }