adding focus and keyboard accessibility to the cookie consent buttons #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bacitracin
reviewed
Oct 11, 2024
| color="tertiary" | ||
| label="Decline" | ||
| startContent={<X />} | ||
| onPress={() => onClickButton(false)} | ||
| /> | ||
|
|
||
| <ThemeButton | ||
| tabIndex={2} |
There was a problem hiding this comment.
This is one of those exceptions to the rule that I think is okay.
Although I have seen it said somewhere on the A11y Slack channel that by now screenreader users just expect that the cookie banner will be on the bottom and they will TAB backwards to get to it.
bacitracin
reviewed
Oct 11, 2024
| @@ -3,12 +3,15 @@ | |||
| import { ThemeButton } from "./ThemeButton"; | |||
| import { Check, X } from "@phosphor-icons/react"; | |||
| import { useCookieContext } from "@/context/CookieContext"; | |||
| import { useEffect, useState } from "react"; | |||
| import { useEffect, useState, useRef } from "react"; | |||
There was a problem hiding this comment.
It looks like you have a couple of small conflicts that need to be resolved with main.
bacitracin
approved these changes
Oct 11, 2024
|
Hi @Amberroseweeks I've changed the PR target branch from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I added positive tab values for the Accept and Decline buttons. This feels a little wrong, I am not sure if this is best practice, but it did seem to work in allowing those items to receive focus first.
This closes issue #859