CB/revert: Revert "Sync git hooks when config file path changed (go-g…

…itea#21619) (go-gitea#21625)"

This reverts commit 7a2daae.

On initial run, this printed
2022/11/07 02:57:24 routers/init.go:90:syncAppConfForGit() [I] CustomConf changed from '' to '/etc/gitea/conf/app.ini'
But for large instances, it's a terrible idea to attempt writing
something to every Git repository *before* starting Gitea.

modules/appstate/item_runtime.go

@@ -6,8 +6,7 @@ package appstate
 
 // RuntimeState contains app state for runtime, and we can save remote version for update checker here in future
 type RuntimeState struct {
-	LastAppPath    string `json:"last_app_path"`
-	LastCustomConf string `json:"last_custom_conf"`
+	LastAppPath string `json:"last_app_path"`
 }
 
 // Name returns the item name

routers/init.go

@@ -74,31 +74,21 @@ func InitGitServices() {
 	mustInit(repo_service.Init)
 }
 
-func syncAppConfForGit(ctx context.Context) error {
+func syncAppPathForGit(ctx context.Context) error {
 	runtimeState := new(appstate.RuntimeState)
 	if err := appstate.AppState.Get(runtimeState); err != nil {
 		return err
 	}
-
-	updated := false
 	if runtimeState.LastAppPath != setting.AppPath {
 		log.Info("AppPath changed from '%s' to '%s'", runtimeState.LastAppPath, setting.AppPath)
-		runtimeState.LastAppPath = setting.AppPath
-		updated = true
-	}
-	if runtimeState.LastCustomConf != setting.CustomConf {
-		log.Info("CustomConf changed from '%s' to '%s'", runtimeState.LastCustomConf, setting.CustomConf)
-		runtimeState.LastCustomConf = setting.CustomConf
-		updated = true
-	}
 
-	if updated {
 		log.Info("re-sync repository hooks ...")
 		mustInitCtx(ctx, repo_service.SyncRepositoryHooks)
 
 		log.Info("re-write ssh public keys ...")
 		mustInit(asymkey_model.RewriteAllPublicKeys)
 
+		runtimeState.LastAppPath = setting.AppPath
 		return appstate.AppState.Set(runtimeState)
 	}
 	return nil
@@ -163,7 +153,7 @@ func GlobalInitInstalled(ctx context.Context) {
 	mustInit(repo_migrations.Init)
 	eventsource.GetManager().Init()
 
-	mustInitCtx(ctx, syncAppConfForGit)
+	mustInitCtx(ctx, syncAppPathForGit)
 
 	mustInit(ssh.Init)