Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Term Entry] Java ArrayList method: .removeRange() #4357

Merged
merged 14 commits into from
Sep 15, 2024
Merged

[Term Entry] Java ArrayList method: .removeRange() #4357

merged 14 commits into from
Sep 15, 2024

Conversation

JA-FY
Copy link
Contributor

@JA-FY JA-FY commented Feb 9, 2024

Description

  • Added the ArrayList.removeRange() term for Java

Issue Solved

Closes Issue #4344

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Feb 9, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ishg-153 ishg-153 self-assigned this Feb 13, 2024
@ishg-153 ishg-153 added java Java entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Feb 14, 2024
@ishg-153 ishg-153 linked an issue Feb 14, 2024 that may be closed by this pull request
[Term Entry] Java ArrayList .removeRange() #4344
Closed
3 tasks
@ishg-153
Copy link
Contributor

Hi @JA-FY ! While I work on reviewing the entry please sign the CLA.

ishg-153
ishg-153 suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JA-FY I've suggested 2 changes, please make them. Let me know once done.

content/java/concepts/array-list/terms/removeRange/removeRange.md Outdated Show resolved Hide resolved
content/java/concepts/array-list/terms/removeRange/removeRange.md Show resolved Hide resolved
@JA-FY
Copy link
Contributor Author

JA-FY commented Feb 16, 2024

Changes made!

ishg-153
ishg-153 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JA-FY This is good for a second review.

@avdhoottt avdhoottt self-assigned this Feb 27, 2024
@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Feb 27, 2024
avdhoottt
avdhoottt requested changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JA-FY, I have suggested some changes, please make them.

content/java/concepts/array-list/terms/removeRange/removeRange.md Show resolved Hide resolved
content/java/concepts/array-list/terms/removeRange/removeRange.md Outdated Show resolved Hide resolved
content/java/concepts/array-list/terms/removeRange/removeRange.md Outdated Show resolved Hide resolved
content/java/concepts/array-list/terms/removeRange/removeRange.md Outdated Show resolved Hide resolved
content/java/concepts/array-list/terms/removeRange/removeRange.md Outdated Show resolved Hide resolved
@ishg-153
Copy link
Contributor

@JA-FY It's been two weeks since @avdhoottt suggested changes. Are you still working on them?

ishg-153 and others added 2 commits March 10, 2024 18:42
@don-mo
Copy link
Contributor

don-mo commented Aug 23, 2024

Hi! If @JA-FY is not making changes, can I take on this issue? I am also taking the git and github course!

@don-mo
Copy link
Contributor

don-mo commented Aug 23, 2024

@ishg-153 and @avdhoottt what does the following mean?
image

avdhoottt
avdhoottt approved these changes Sep 15, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avdhoottt avdhoottt merged commit fbe74d2 into Codecademy:main Sep 15, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @JA-FY
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/java/array-list/removeRange

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sriparno08 pushed a commit to FelixOmollo/docs that referenced this pull request Sep 20, 2024
@JA-FY @Sriparno08
[Term Entry] Java ArrayList method: .removeRange() (Codecademy#4357)
c07b21f 
* Add Java ArrayList.removeRange() term entry

* Clarify pseudocode logic and format output example to match actual code behavior

* fix(note): move outside code block

* feat: correct sentence structures and formats.

Co-authored-by: Avdhoot <50920321+avdhoottt@users.noreply.github.com>

* feat: add parameter description.

* Errors Fixed

* Update content/java/concepts/array-list/terms/removeRange/removeRange.md

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishg-153 ishg-153 ishg-153 approved these changes

@avdhoottt avdhoottt avdhoottt approved these changes

Assignees

@avdhoottt avdhoottt

@ishg-153 ishg-153

Labels
java Java entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Java ArrayList .removeRange()
5 participants
@JA-FY @CLAassistant @ishg-153 @don-mo @avdhoottt