Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create index and columns #4597

Merged
merged 8 commits into from
May 12, 2024
Merged

Create index and columns #4597

merged 8 commits into from
May 12, 2024

Conversation

0-Brandon
Copy link
Contributor

Description

Added entries for the .index and .columns attributes of DataFrames.

Issue Solved

Closes #4518
Closes #4519

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@mohitO12-dev mohitO12-dev self-assigned this Apr 30, 2024
@mohitO12-dev mohitO12-dev added new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Apr 30, 2024
@mohitO12-dev mohitO12-dev removed their assignment Apr 30, 2024
@letsbuildanything letsbuildanything self-assigned this Apr 30, 2024
@letsbuildanything letsbuildanything added the pandas Python:Pandas entries label Apr 30, 2024
letsbuildanything
letsbuildanything suggested changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0-Brandon
Thank you for contributing to Codecademy Docs!
I've requested below some changes. Please make them.

content/pandas/concepts/dataframe/terms/columns/columns.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/columns/columns.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/columns/columns.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/columns/columns.md Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/columns/columns.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/index/index.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/index/index.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/index/index.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/index/index.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/index/index.md Show resolved Hide resolved
@0-Brandon @letsbuildanything
Apply suggestions from review
ce50200 
Co-authored-by: Pankaj <101002817+letsbuildanything@users.noreply.github.com>
letsbuildanything
letsbuildanything approved these changes May 5, 2024
View reviewed changes
Copy link
Contributor

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for second round of review!

@Sriparno08 Sriparno08 self-assigned this May 6, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 6, 2024
@Sriparno08 Sriparno08 removed their assignment May 8, 2024
@Sriparno08 Sriparno08 added status: ready for next review and removed status: under review Issue or PR is currently being reviewed labels May 8, 2024
@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 9, 2024
@avdhoottt avdhoottt self-assigned this May 9, 2024
avdhoottt
avdhoottt requested changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @0-Brandon, I've suggested a minor change. Please make it and let me know when you are done.

content/pandas/concepts/dataframe/terms/columns/columns.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/index/index.md Outdated Show resolved Hide resolved
@avdhoottt avdhoottt added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 9, 2024
@0-Brandon @avdhoottt
Apply changes
dc53ad8 
Co-authored-by: Avdhoot <50920321+avdhoottt@users.noreply.github.com>
@0-Brandon 0-Brandon requested a review from avdhoottt May 12, 2024 16:43
avdhoottt
avdhoottt approved these changes May 12, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@avdhoottt avdhoottt merged commit b7045de into Codecademy:main May 12, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @0-Brandon
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pandas/dataframe/columns
https://www.codecademy.com/resources/docs/pandas/dataframe/index

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdhoottt avdhoottt avdhoottt approved these changes

@letsbuildanything letsbuildanything letsbuildanything approved these changes

Assignees

@avdhoottt avdhoottt

@letsbuildanything letsbuildanything

Labels
new entry New entry or entries pandas Python:Pandas entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python:Pandas dataframe columns [Term Entry] Python:Pandas dataframe index
5 participants
@0-Brandon @avdhoottt @letsbuildanything @Sriparno08 @mohitO12-dev