Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I add how to use group selector in selectors.md #4603

Merged
merged 7 commits into from
May 10, 2024
Merged

I add how to use group selector in selectors.md #4603

merged 7 commits into from
May 10, 2024

Conversation

gurpiar03
Copy link
Contributor

@gurpiar03 gurpiar03 commented May 2, 2024 •
edited by SaviDahegaonkar
Loading

Description

I have made update in selectors.md in CSS. i put a topic of group selector in it which was not there but it is important. When one or more selectors have same style. we can use group selector to minimize the code

Issue Solved

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.

@CLAassistant
Copy link

CLAassistant commented May 2, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Sriparno08 Sriparno08 self-assigned this May 3, 2024
@Sriparno08 Sriparno08 added enhancement New feature or request css CSS entries status: under review Issue or PR is currently being reviewed labels May 3, 2024
Sriparno08
Sriparno08 approved these changes May 4, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a second review! 👍

@avdhoottt avdhoottt added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels May 4, 2024
@avdhoottt avdhoottt self-assigned this May 4, 2024
avdhoottt
avdhoottt approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@avdhoottt avdhoottt added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels May 10, 2024
@avdhoottt avdhoottt merged commit 09cb4fe into Codecademy:main May 10, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @gurpiar03
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/css/selectors

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

achur00 pushed a commit to achur00/Codecademy-docs that referenced this pull request May 11, 2024
@gurpiar03 @achur00
I add how to use group selector in selectors.md (Codecademy#4603)
dbd7e31 
* I add how to use group selector in selectors.md

* Minor changes

* Prettier formating

* Update content/css/concepts/selectors/selectors.md

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdhoottt avdhoottt avdhoottt approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@avdhoottt avdhoottt

@Sriparno08 Sriparno08

Labels
css CSS entries enhancement New feature or request status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gurpiar03 @CLAassistant @avdhoottt @Sriparno08 @dakshdeepHERE