Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Entry Term] Neural Networks ai adam optimization #4690

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
Open

[Entry Term] Neural Networks ai adam optimization #4690

wants to merge 47 commits into from

Conversation

TimLyons87
Copy link

@TimLyons87 TimLyons87 commented May 22, 2024 •
edited
Loading

Description

Issue Solved

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@TimLyons87
Create Adam-Optimization.md
a165d53 
Term entry markdown file covering adam optimization use in ai and neural networks.
@TimLyons87
Merge branch 'Codecademy:main' into Neural-Networks-ai-adam-optimization
74ba0bf
@TimLyons87
Added term entry title to .md doc
40843ed
@TimLyons87
Added document description
3f7e9c4
@TimLyons87
Added three subjects to term entry doc
e31c2c4
@TimLyons87
Added six tags to term entry doc
5ab9eb7
@TimLyons87
Added two catalog contents
fab32d5
@TimLyons87
Added long description
bf597ba
@TimLyons87
Added syntax with example code
bb6d28f
@TimLyons87
Update to syntax
be5f1f8
@TimLyons87
Added new sections to doc
f6d57ef
@TimLyons87
Added detail to Adam Optimization section
a7c2fc5
@TimLyons87
Added python syntax and codebyte
a7dfc26
@TimLyons87
Update codebyte link and added code source
a24763d
@TimLyons87
Update document spelling, grammar, and added content to
7c4ca71
@TimLyons87
Create adam optimization term for ai neural network
573ec3c
@TimLyons87
Merge branch 'Codecademy:main' into main
1d3e831
@CLAassistant
Copy link

CLAassistant commented May 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this May 23, 2024
@mamtawardhani
Copy link
Collaborator

Hey @TimLyons87! The submitted entry is empty, could you please check?

@mamtawardhani mamtawardhani added new entry New entry or entries status: waiting for author status: under review Issue or PR is currently being reviewed ai Artificial Intelligence entries labels May 23, 2024
@TimLyons87
Copy link
Author

@mamtawardhani adam-optimization.md is in my repositorties' main branch. I have attempted to change it to the correct repository and it should be ready for review now. Thank you very much for your continued patience.

@mamtawardhani
Copy link
Collaborator

@TimLyons87 I can still see an empty entry, you need to create a feature branch for this, it should not be on the main branch. I think you can raise another Pull request by adding the content on the featured branch.

TimLyons87 and others added 8 commits June 2, 2024 07:01
@TimLyons87 @mamtawardhani
Update content/ai/concepts/neural-networks/terms/Adam-Optimization/Ad…
593b491 
…am-Optimization.md


Accpted collaborator-suggested edits.

Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@TimLyons87
Merge branch 'Codecademy:main' into Neural-Networks-ai-adam-optimization
2b6856c
@TimLyons87 @mamtawardhani
Update content/ai/concepts/neural-networks/terms/Adam-Optimization/Ad…
c7c0d99 
…am-Optimization.md


Accpted collaborator-suggested edits.

Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@TimLyons87 @mamtawardhani
Update content/ai/concepts/neural-networks/terms/Adam-Optimization/Ad…
ded63a9 
…am-Optimization.md


Updated heading to 'How Adam Optimization Works' for better clarity.

Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@TimLyons87 @mamtawardhani
Update content/ai/concepts/neural-networks/terms/Adam-Optimization/Ad…
32316f8 
…am-Optimization.md


Accpeted collaborator-suggested edits.

Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@TimLyons87
Added comments and suggestions to Adam Optimization doc
4c50084
@TimLyons87
Added final formatting to Adam Optimization doc
6150053
@TimLyons87
Merge branch 'Codecademy:main' into Neural-Networks-ai-adam-optimization
58ae98c
@TimLyons87
Copy link
Author

@mamtawardhani I have reviewed and included the requested changes to the Adam Optimization document. It is now ready for your review. Thank you.

mamtawardhani
mamtawardhani approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the required changes @TimLyons87! 😄

It looks good for a second review!

@ishg-153 ishg-153 self-assigned this Jun 3, 2024
@ishg-153 ishg-153 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jun 3, 2024
@ishg-153 ishg-153 linked an issue Jun 3, 2024 that may be closed by this pull request
[Term Entry] Neural Networks ai adam optimization #4528
Open
3 tasks
@ishg-153
Copy link
Collaborator

ishg-153 commented Jun 3, 2024

Hey @TimLyons87! You need to sign the CLA. Please do so from the @CLAassistant comment.

@TimLyons87
Copy link
Author

@ishg-153 @mamtawardhani I have signed the CLA assistant agreement. Thank you both for your patience. Please let me know if you find any other errors or have other edits. Thanks again, Tim.

ishg-153
ishg-153 requested changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimLyons87 Sorry for the delayed review. This entry is too long to be a docs entry. You will have to reduce the length and details of the entry. Docs entries are expected to be bite-sized well-rounded explanations. Use this similar entry as a base for structure.

Also make the following change.

content/ai/concepts/neural-networks/terms/Adam-Optimization/Adam-Optimization.md
- 'Machine Learning'
- 'Neural Networks'
- 'Optimization'
- 'Weights & Bias'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- 'Weights & Bias'
- 'Weight & Bias'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishg-153 ishg-153 ishg-153 requested changes

@mamtawardhani mamtawardhani mamtawardhani approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@mamtawardhani mamtawardhani

@ishg-153 ishg-153

Labels
ai Artificial Intelligence entries new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed status: waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Neural Networks ai adam optimization
5 participants
@TimLyons87 @CLAassistant @mamtawardhani @ishg-153 @mohitO12-dev