Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codebytes to JS Accessors #4818 #4843

Merged
merged 8 commits into from
Jun 30, 2024

Conversation

ryanrackemann
Copy link
Contributor

Description

I have updated the Javascript Accessors page to include a Codebyte example.

Issue Solved

closes #4818

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@avdhoottt avdhoottt self-assigned this Jun 27, 2024
@avdhoottt avdhoottt added enhancement New feature or request javascript JavaScript entries status: under review Issue or PR is currently being reviewed labels Jun 27, 2024
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the second review!

@letsbuildanything letsbuildanything added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jun 29, 2024
@letsbuildanything letsbuildanything self-assigned this Jun 29, 2024
@letsbuildanything letsbuildanything added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jun 30, 2024
Copy link
Contributor

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryanrackemann Thank you for contributing to the Codecademy Docs!
This Looks good to be Merged! 🚀

@letsbuildanything letsbuildanything merged commit cdeada3 into Codecademy:main Jun 30, 2024
6 checks passed
Copy link

👋 @ryanrackemann
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/javascript/accessors

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Edit] JavaScript [Edit] JavaScript: Accessors
3 participants