Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .md file/entry for Pandas dataframe tail #4855

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

sethaferd
Copy link

Description

Added .md file/entry for Pandas dataframe tail.

Issue Solved

Closes #4523

Type of Change

  • Adding a new entry

Checklist

  • [ x ] All writings are my own.
  • [ x ] My entry follows the Codecademy Docs style guide.
  • [ x ] My changes generate no new warnings.
  • [ x ] I have performed a self-review of my own writing and code.
  • [ x ] I have checked my entry and corrected any misspellings.
  • [ x ] I have made corresponding changes to the documentation if needed.
  • [ x ] I have confirmed my changes are not being pushed from my forked main branch.
  • [ x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [ x ] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Jul 1, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries pandas Python:Pandas entries status: under review Issue or PR is currently being reviewed labels Jul 1, 2024
@mamtawardhani
Copy link
Collaborator

Hey @sethaferd, seems like the path of entry is incorrect as the tail.md file should be inside a folder named tail, could you please update that? This is how your final path should look like: docs/content/pandas/concepts/dataframe/terms/tail/tail.md.

Let me know once you update it 😃

@mamtawardhani mamtawardhani added status: waiting for author and removed status: under review Issue or PR is currently being reviewed labels Jul 1, 2024
@sethaferd
Copy link
Author

@mamtawardhani updated! thank you for the feedback.

@mamtawardhani mamtawardhani added status: under review Issue or PR is currently being reviewed and removed status: waiting for author labels Jul 2, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sethaferd, thank you for contributing to the Codecademy Docs, the entry is nicely written!

I've requested some minor changes, could you please review and modify them at your earliest convenience? Thank you! 😃

content/pandas/concepts/dataframe/terms/tail/tail.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/tail/tail.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/tail/tail.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/tail/tail.md Outdated Show resolved Hide resolved
content/pandas/concepts/dataframe/terms/tail/tail.md Outdated Show resolved Hide resolved
sethaferd and others added 5 commits July 2, 2024 15:33
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
minor changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @sethaferd! 😃

The entry looks good for a second review 🚀

@Sriparno08 Sriparno08 self-assigned this Jul 2, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new entry New entry or entries pandas Python:Pandas entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python:Pandas dataframe tail
4 participants