Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Flatten docs #4875

Merged
merged 16 commits into from
Jul 8, 2024
Merged

Adding Flatten docs #4875

merged 16 commits into from
Jul 8, 2024

Conversation

BaljiSubramani
Copy link
Contributor

Description

Adding doc for flatten module

Issue Solved

Type of Change

  • Adding a new entry for Flatten

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@mamtawardhani mamtawardhani self-assigned this Jul 2, 2024
@mamtawardhani mamtawardhani added new entry New entry or entries numpy NumPy entries status: under review Issue or PR is currently being reviewed labels Jul 2, 2024
@mamtawardhani mamtawardhani linked an issue Jul 2, 2024 that may be closed by this pull request
[Term Entry] Python:NumPy ndarray .flatten() #4831
Closed
3 tasks
mamtawardhani
mamtawardhani requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BaljiSubramani, thank you for contributing to DCodecademy Docs, the entry is nicely written! 😃

I've suggested a few changes, could you please review and modify those at your earliest convenience? Feel free to discuss any concerns. Thank you! 😄

content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
content/numpy/concepts/ndarray/terms/flatten/flatten.md Outdated Show resolved Hide resolved
BaljiSubramani and others added 10 commits July 3, 2024 13:20
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
a47fbfa 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
4bce905 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
503caba 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
41f9506 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
e3ac9fc 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
d3931f5 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
2aee2dd 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
86406bc 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani @mamtawardhani
Update content/numpy/concepts/ndarray/terms/flatten/flatten.md
b106645 
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@BaljiSubramani
Review finding fix
5fe57da
@BaljiSubramani
Copy link
Contributor Author

Can you please perform a review again on latest commit? Thank you!

@mamtawardhani
Update flatten.md
1b8128f 
minor changes
mamtawardhani
mamtawardhani approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @BaljiSubramani! 😃

The entry looks good for a second round of review!

@BaljiSubramani
Copy link
Contributor Author

@mamtawardhani : Many Thanks for review and time spent on this topic :-) . Nice working with you!

@Sriparno08 Sriparno08 self-assigned this Jul 3, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jul 3, 2024
Sriparno08
Sriparno08 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @BaljiSubramani! 👍

@Sriparno08 Sriparno08 merged commit 10680cd into Codecademy:main Jul 8, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

👋 @BaljiSubramani
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pandas/dataframe/tail

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamtawardhani mamtawardhani mamtawardhani approved these changes

@Sriparno08 Sriparno08 Sriparno08 approved these changes

Assignees

@mamtawardhani mamtawardhani

@Sriparno08 Sriparno08

Labels
new entry New entry or entries numpy NumPy entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python:NumPy ndarray .flatten()
3 participants
@BaljiSubramani @mamtawardhani @Sriparno08