Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Term Entry] Python Math Module comb() #4348 #4885

Merged
merged 17 commits into from
Jul 23, 2024
Merged

Conversation

aSagCoder
Copy link
Contributor

Description

  • Added the math.com() function for Python math-module.
  • Can be located here - content/python/concepts/math-module/terms/math-comb/math-comb.md

Issue Solved

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

Created a new term entry 'math.comb()' for the Math Module in Python.
corrected typos, editing errors, etc.
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Jul 8, 2024
@mamtawardhani mamtawardhani added python Python entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Jul 8, 2024
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your Contribution to the Codecademy Docs @aSagCoder, the entry is nicely written! 😃

I've suggested a few changes, could you please review and modify them at your earliest convenience? Thank you! 😄

@aSagCoder
Copy link
Contributor Author

Thank you for the review, @mamtawardhani ! Since this is my first time contributing in a technical writing oriented repo, these insights and suggestions are very helpful. I will try to make the necessary changes as soon as possible.

aSagCoder and others added 6 commits July 13, 2024 23:59
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Copy link
Contributor Author

@aSagCoder aSagCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mamtawardhani Hi there, I have reviewed and added the suggestions you made! Thank you for reviewing my PR and I hope everything looks good to go now.

minor changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @aSagCoder 😃

The entry is ready for a second round of review! 🚀

@Sriparno08 Sriparno08 added the status: under review Issue or PR is currently being reviewed label Jul 18, 2024
@Sriparno08 Sriparno08 self-assigned this Jul 18, 2024
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @aSagCoder! 👍

For your next contributions, please create and make changes on a new branch (not the main branch) and then open a PR from it.

@Sriparno08 Sriparno08 merged commit 67b830d into Codecademy:main Jul 23, 2024
6 checks passed
Copy link

👋 @aSagCoder
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/python/math-module/math-comb

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Python Math Module comb()
4 participants