-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Term Entry] Python Math Module comb() #4348 #4885
Conversation
Created a new term entry 'math.comb()' for the Math Module in Python.
corrected typos, editing errors, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your Contribution to the Codecademy Docs @aSagCoder, the entry is nicely written! 😃
I've suggested a few changes, could you please review and modify them at your earliest convenience? Thank you! 😄
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
content/python/concepts/math-module/terms/math-comb/math-comb.md
Outdated
Show resolved
Hide resolved
Thank you for the review, @mamtawardhani ! Since this is my first time contributing in a technical writing oriented repo, these insights and suggestions are very helpful. I will try to make the necessary changes as soon as possible. |
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mamtawardhani Hi there, I have reviewed and added the suggestions you made! Thank you for reviewing my PR and I hope everything looks good to go now.
minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @aSagCoder 😃
The entry is ready for a second round of review! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @aSagCoder! 👍
For your next contributions, please create and make changes on a new branch (not the main branch) and then open a PR from it.
👋 @aSagCoder 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/python/math-module/math-comb Please note it may take a little while for changes to become visible. |
Description
Issue Solved
Type of Change
Editing an existing entry (fixing a typo, bug, issues, etc)Updating the documentationChecklist
main
branch.Issues Solved
section.