Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add image for example code in flex-basis.md #4886

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Add image for example code in flex-basis.md #4886

merged 12 commits into from
Aug 13, 2024

Conversation

George-Hiatt-Git
Copy link
Contributor

Description

Issue Solved

Closes #4870

Created an image to depict the example code in the flex-basis entry.
Image saved as /media/css-flex-basis-example-output.png.
Images used for creation of example are all royalty free/public domain.

Type of Change

  • Editing an existing entry (fixing a typo, bug, issues, etc)

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jul 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ishg-153 ishg-153 self-assigned this Jul 8, 2024
@ishg-153 ishg-153 added enhancement New feature or request css CSS entries status: under review Issue or PR is currently being reviewed labels Jul 8, 2024
ishg-153
ishg-153 suggested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@George-Hiatt-Git I have suggested some changes. Please make them and let me know once you are done.

content/css/concepts/flexbox/terms/flex-basis/flex-basis.md Outdated Show resolved Hide resolved
content/css/concepts/flexbox/terms/flex-basis/flex-basis.md Outdated Show resolved Hide resolved
content/css/concepts/flexbox/terms/flex-basis/flex-basis.md Outdated Show resolved Hide resolved
George-Hiatt-Git and others added 3 commits July 8, 2024 16:35
@George-Hiatt-Git @ishg-153
Update flex-basis.md example image text
fa48186 
Co-authored-by: Ishwari Garge <ishwarigarge@gmail.com>
@George-Hiatt-Git @ishg-153
Remove commenting from final version
1265f93 
Co-authored-by: Ishwari Garge <ishwarigarge@gmail.com>
@George-Hiatt-Git @ishg-153
Update alt image text and clean image href
ba7bf0b 
Co-authored-by: Ishwari Garge <ishwarigarge@gmail.com>
@George-Hiatt-Git
Copy link
Contributor Author

@George-Hiatt-Git I have suggested some changes. Please make them and let me know once you are done.

Hi thank you for the feedback, I believe I've committed the necessary edits but please let me know if you need anything else.

ishg-153
ishg-153 suggested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@George-Hiatt-Git You forgot this one change. Please make it and let me know once done.

content/css/concepts/flexbox/terms/flex-basis/flex-basis.md Outdated Show resolved Hide resolved
@George-Hiatt-Git
Copy link
Contributor Author

@George-Hiatt-Git You forgot this one change. Please make it and let me know once done.

Apologies, I've now made a commit to change the image link to the correct format.

ishg-153
ishg-153 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@ishg-153 ishg-153 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@George-Hiatt-Git This is ready for a second review!

@letsbuildanything letsbuildanything added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jul 14, 2024
@letsbuildanything letsbuildanything self-assigned this Jul 14, 2024
@letsbuildanything letsbuildanything removed the status: under review Issue or PR is currently being reviewed label Jul 31, 2024
letsbuildanything
letsbuildanything approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@letsbuildanything letsbuildanything left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to Me!

@letsbuildanything letsbuildanything merged commit 820ae38 into Codecademy:main Aug 13, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

👋 @George-Hiatt-Git
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/css/flexbox/flex-basis

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishg-153 ishg-153 ishg-153 approved these changes

@letsbuildanything letsbuildanything letsbuildanything approved these changes

Assignees

@ishg-153 ishg-153

@letsbuildanything letsbuildanything

Labels
css CSS entries enhancement New feature or request status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Edit] CSS [Edit] CSS: Flexbox flex-basis
4 participants
@George-Hiatt-Git @CLAassistant @ishg-153 @letsbuildanything