Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create data-types.md #4908

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Create data-types.md #4908

wants to merge 4 commits into from

Conversation

A1cX
Copy link
Contributor

@A1cX A1cX commented Jul 10, 2024 •
edited by cigar-galaxy82
Loading

data types md file

Description

PR is linked to MySQL data-types #4675 issue assigned to me and it is an .md file describing usage, syntax and examples of various MySQL data types.

Issue Solved

#4675

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

A1cX and others added 3 commits July 10, 2024 18:45
@cigar-galaxy82 cigar-galaxy82 self-assigned this Jul 20, 2024
@cigar-galaxy82 cigar-galaxy82 added new entry New entry or entries status: under review Issue or PR is currently being reviewed mysql MySQL labels Jul 26, 2024
cigar-galaxy82
cigar-galaxy82 requested changes Jul 27, 2024
View reviewed changes
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Outdated Show resolved Hide resolved
content/mysql/concepts/data-types/data-types.md Show resolved Hide resolved
@cigar-galaxy82
Copy link
Collaborator

Hi, @A1cX thank you for contributing to Codecademy docs, the entry is well written. I have suggested a few changes please modify

@A1cX
Update data-types.md
2edb11c 
- added all corrections as requested, thank you

couldn't yarn, prettier this file ( I have problems with my system, could not today run prettier, I'm sorry. I will fix storage, I have problems maybe from not enough space, it happened before).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cigar-galaxy82 cigar-galaxy82 cigar-galaxy82 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@cigar-galaxy82 cigar-galaxy82

Labels
mysql MySQL new entry New entry or entries status: review 1️⃣ completed status: waiting for author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@A1cX @cigar-galaxy82