Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed iOS related display issues #570

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Fixed iOS related display issues #570

merged 1 commit into from
Apr 2, 2021

Conversation

Danielku15
Copy link
Member

@Danielku15 Danielku15 commented Apr 2, 2021

added polyfill for intersectionobserver and handle dominant-baseline correctly.

Issues

Fixes #556

Proposed changes

Apply dominant-baseline via CSS style and add polyfill for IntersectionObserver (iOS 11 compat)

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

added polyfill for intersectionobserver and handle dominant-baseline correctly.
@Danielku15 Danielku15 self-assigned this Apr 2, 2021
@Danielku15 Danielku15 merged commit 657f884 into develop Apr 2, 2021
@Danielku15 Danielku15 deleted the feature/issue-556 branch April 2, 2021 17:35
Danielku15 added a commit that referenced this pull request Apr 2, 2021
Danielku15 added a commit that referenced this pull request Apr 2, 2021
* Fixed iOS related display issues (#570)
* Fixed some scaling issue (#564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For iOS devices, tab numbers are not vertically centered to the lines
1 participant