Custom exceptions instead of sys.exit in Hiscores #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Hiscores.py
it is not possible to work with library in applications like Discord bots. One can useexcept SystemExit
, but in this case error message will be left out of control flow (e.g. logging).Proposition
If
sys.exit()
is replaced by custom exception it is possible to try-except invocation ofHiscores()
and gracefully process errorsImpact on current implementation
0
means that program has been executed successfully and didn't return any errors. Taking that fact into account, uncaught exception is even more preferable because it will result exit code 1, which indicates error in runtime.