Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape username for invalid URL characters (ie. spaces) #12

Closed

Conversation

tylersweat
Copy link
Contributor

Using Python3's built-in urllib package, escape the username so that the Hiscores will still work for a username containing a space without throwing an exception.

Before:
image

After:
image

@Coffee-fueled-deadlines
Copy link
Owner

While a good idea, I'd rather not import an additional library (urllib) to fix an issue with a space in the name. Most likely I'll use a .replace(" ","%20") do accomplish the same thing without the need for an additional library. Thank you though.

@tylersweat
Copy link
Contributor Author

I'll go make that change.

@tylersweat tylersweat closed this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants