Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Indentation issues #33

Closed
wants to merge 5 commits into from

Conversation

lordsherman
Copy link

No description provided.

@lordsherman
Copy link
Author

lordsherman commented Jan 22, 2023

This Indentation issue appears to be causing the inability to use the update function on the Items class. There was also a small typo in the items invocation example.

There was a mix of spaces and tabs. The main file seems to use tabs exclusively so I have removed all the spaces.

@lordsherman lordsherman changed the title Fix example typo Fix Indentation issues Jan 22, 2023
@Coffee-fueled-deadlines
Copy link
Owner

Thank you for the work put into it, a few notes:

  1. While the majority of the file does, in fact, use tabs: pep standard actually prefers and leans towards spaces. This is a planned fix in the 1.3.1 version.
  2. Changes made to the package should be pushed to dev, not to master.

@Coffee-fueled-deadlines
Copy link
Owner

If you fetch dev, you'll note that I've just converted all tabs to spaces. You're free to merge in the missing ) on the readme file though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants