Fixed typo defense->defence #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting thought. In actuality, defense and defence are both correct. It just has to do with the location in which one is currently living. In the UK/Great Britain they spell it as defence and in the US it is spelled as defense. As I'm from the US, I ended up spelling it as defense. That being said, this could go back and forth for awhile depending on the locality of the person that's doing the commit (albeit it is spelled the British way in game). I'm not going to accept the pull request, however, as I feel the point is moot and would result in juggling back and forth. A work around would be to simply add a redundant key in the dictionary that spells it as Defence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assume this is a typo?