Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'total' as a skill #47

Conversation

jackbrown1993
Copy link

@Coffee-fueled-deadlines are you happy for the total to be processed as a skill so handling for level, rank and XP is consistent? Also seems to fix issue I was facing in #46

@Coffee-fueled-deadlines
Copy link
Owner

Total is already handled as a skill, see attached screenshot:

image

@jackbrown1993
Copy link
Author

jackbrown1993 commented Nov 10, 2023

As per your screenshot and #46 the XP shown for total is wrong. What is \n1211768

@Coffee-fueled-deadlines
Copy link
Owner

As per your screenshot and #46 the XP shown for total is wrong. What is \n1211768

That part is an error, correct. However total is already handled as a skill.

Total processing begins here

and then it's added to the skills dictionary here

In your branch here the removal of the pop(0) is removing the removal of redundant data that was already calculated and added total into the skills as you have would just result in the total being overwritten again with a new total key.

@Coffee-fueled-deadlines
Copy link
Owner

Pull request must be made to dev not master. Ensure that all changes on your end are done to dev as well. Master is only updated when a new release is made.

In addition to what was stated above, please make sure you're working in dev and not on master directly. For this pull request, I honestly suggest just parsing off the \n with something like

info['experience'] = total_info[2].split("\n",1)[0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants