Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/css customization v3 #21

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Feature/css customization v3 #21

merged 8 commits into from
Sep 17, 2024

Conversation

sushmi21
Copy link
Contributor

@sushmi21 sushmi21 commented Sep 6, 2024

Success criteria

Please describe what should be possible after this change. List all individual items on a separate line.

  • Add missing classes to css-customization document
  • Rename some classes to have meaningful and appropriate names

How to test

Please describe the individual steps on how a peer can test your change.

  1. Newly introduced classes are added to the css-customization document
  2. webchat-chat-options-root is renamed to webchat-chat-options-action-btns-root
  3. webchat-chat-options-button is renamed to webchat-chat-options-action-button
  4. webchat-chat-options-button-container is renamed to webchat-chat-options-action-button-container

NOTE: The renaming can have breaking style changes for some customers. This should be mentioned in the release notes

Security

  • Possible injection vector
  • Authentication/Access controls touched
  • Sensitive Data could be exposed
  • XSS
  • Logging/Monitoring touched
  • Exchanges data with external systems
  • No security implications

Additional considerations

  • This PR might have performance implications

@sushmi21 sushmi21 requested a review from kwinto September 6, 2024 14:22
kwinto
kwinto previously approved these changes Sep 16, 2024
@sushmi21 sushmi21 merged commit 87bd75b into main Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants