Elastic 6 #2
Open
Elastic 6 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Glad to see you are interested in this project! This project is still an experimental project for Prometheus 2.0 remote storage feature, and I even not implement elastic read yet.. But I'm happy to review PR :) |
Colstuwjx
reviewed
Feb 15, 2018
|
|
||
| "github.com/prometheus/client_golang/prometheus" | ||
| "github.com/prometheus/common/log" | ||
| "github.com/prometheus/common/model" | ||
| elastic "gopkg.in/olivere/elastic.v3" | ||
| "github.com/olivere/elastic" |
There was a problem hiding this comment.
Could you update client_test.go? Since the pkg name changed, test case has also been broken.
Colstuwjx
reviewed
Mar 8, 2018
| version = "6.1.7" | ||
|
|
||
| [[constraint]] | ||
| name = "gopkg.in/olivere/elastic.v3" |
There was a problem hiding this comment.
It seems that we don't need this constraint any more, dependencies and vendor should also be updated :)
There was a problem hiding this comment.
Oh whoops, Ill do a vendor ensure and prune :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really cool project!
depfor dependency management