Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N°824 - Allow OQL JOIN on object ON EventNotification #642

Merged
merged 6 commits into from
Sep 19, 2024

Conversation

accognet
Copy link
Contributor

@accognet accognet commented Apr 5, 2024

Add a new object_class field in EventNotification to be used in a future version of iTop

@accognet accognet added the enhancement New feature or request label Apr 5, 2024
@accognet accognet self-assigned this Apr 5, 2024
@accognet accognet changed the title Feature/824 add object class on event notification N°824 - Allow OQL JOIN on object_id ON EventNotification Apr 5, 2024
@accognet accognet changed the title N°824 - Allow OQL JOIN on object_id ON EventNotification N°824 - Allow OQL JOIN on object ON EventNotification Apr 5, 2024
@Molkobain
Copy link
Contributor

Support PRs review:

  • Anne-Cath will ask Vincent if we want to display the "Notifications" tab even when no trigger but existing notifications (code to be done)
  • Data migration during setup has been done (mind to reset "previous version " to 3.2 instead of 3.3)

@Molkobain Molkobain added the internal Work made by Combodo label Apr 15, 2024
@accognet accognet changed the base branch from develop to support/3.2 April 16, 2024 12:25
@rquetiez rquetiez self-requested a review June 6, 2024 20:20
@rquetiez
Copy link
Contributor

rquetiez commented Jun 6, 2024

Data migration during might have an impact on the duration of the setup. This impact has to be evaluated and documented.

@Molkobain
Copy link
Contributor

Functional review: Accepted for 3.3.

There are still tests to do on a huge database (1.5M+ EventNotifications) to anticipate queries duration during the setup; and we are too close to the 3.2 code freeze to manage it.
Tests have already be done on a smaller DB (300k EventNotifications), results can be found on the drive under R&D > Studies

@Molkobain Molkobain added this to the 3.3.0 milestone Jul 10, 2024
@Molkobain
Copy link
Contributor

@accognet please :

  • Change target branch to develop
  • "Rebase onto" your branch on develop instead of support/3.2
  • Resolve conflicts
  • Then you can squash & merge on develop

@accognet accognet force-pushed the feature/824-add_object_class_on_EventNotification branch from dd21923 to 1435f7a Compare September 19, 2024 06:56
@accognet accognet changed the base branch from support/3.2 to develop September 19, 2024 06:56
@accognet accognet merged commit f3a6b06 into develop Sep 19, 2024
@accognet accognet deleted the feature/824-add_object_class_on_EventNotification branch September 19, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal Work made by Combodo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants