Skip to content

Commit

Permalink
fix check_runtime diff
Browse files Browse the repository at this point in the history
  • Loading branch information
seunlanlege committed Jan 28, 2022
1 parent 0485d39 commit 6a9f2b9
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .maintain/common/lib.sh
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ has_client_changes() {
# checks if the spec/impl version has increased
check_runtime() {
VERSIONS_FILE="$1"
add_spec_version="$(git diff "${LATEST_TAG_NAME}" "${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
add_spec_version="$(git diff "${LATEST_TAG_NAME}" "origin/${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
sed -n -r "s/^\+[[:space:]]+spec_version: +([0-9]+),$/\1/p")"
sub_spec_version="$(git diff "${LATEST_TAG_NAME}" "${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
sub_spec_version="$(git diff "${LATEST_TAG_NAME}" "origin/${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
sed -n -r "s/^\-[[:space:]]+spec_version: +([0-9]+),$/\1/p")"
if [ "${add_spec_version}" != "${sub_spec_version}" ]; then

Expand All @@ -70,9 +70,9 @@ check_runtime() {
# check for impl_version updates: if only the impl versions changed, we assume
# there is no consensus-critical logic that has changed.

add_impl_version="$(git diff "${LATEST_TAG_NAME}" "${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
add_impl_version="$(git diff "${LATEST_TAG_NAME}" "origin/${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
sed -n -r 's/^\+[[:space:]]+impl_version: +([0-9]+),$/\1/p')"
sub_impl_version="$(git diff "${LATEST_TAG_NAME}" "${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
sub_impl_version="$(git diff "${LATEST_TAG_NAME}" "origin/${GITHUB_BRANCH_NAME}" -- "${VERSIONS_FILE}" |
sed -n -r 's/^\-[[:space:]]+impl_version: +([0-9]+),$/\1/p')"

# see if the impl version changed
Expand Down

0 comments on commit 6a9f2b9

Please sign in to comment.