Add retry mechanism to deal with flaky KeyError #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit confused. Didn't you apply this fix in #40? |
Yes, we did. But it was merged into master and not main🙃 |
|
Ah, so are we not using |
|
Nope, |
|
Still seems to be a problem though: https://github.com/ComputationalPhysiology/goss/actions/runs/4124734861/jobs/7124354344#step:6:868 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unable to find out what causes this key error, but the problem is occuring when differentiation the expressions. The
_xi_nvariables are dummy variables introduced by sympy, see e.g sympy/sympy#13791Retrying to initialise the component seems to work, so this is a possible fix.
Fix #24