-
-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(deps): remove transitive dependency on chrono
chrono is a worrying crate to depend on, because it depends on old versions of the time crate with known security problems. PackSquash is not affected by these, and overall upstream does not consider the issue very important, but as GitHub advisories are rolled out for it, silecing all the security warnings in this convoluted transitive dependency mess gets cumbersome quickly. Luckily, chrono is only used by wmi-rs on Windows platforms. The rest of the ecosystem has been moving away from it, and wmi-rs now has a feature flag to directly use the time crate instead. Let's enable it to pull less transitive dependencies and properly fix all these warnings.
- Loading branch information
1 parent
cb80c97
commit 25e5153
Showing
3 changed files
with
13 additions
and
45 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25e5153
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PackSquash library quick benchmarks
tiny_benches_wall_time/empty_pack
11062780
ns/iter (± 614810
)14101526
ns/iter (± 729030
)0.78
small_benches_wall_time/aylas_khron_micro_pack
718878236
ns/iter (± 8208731
)762389944
ns/iter (± 7702052
)0.94
small_benches_wall_time/jilchu_chronos_micro_pack
13454882747
ns/iter (± 32847793
)15590937195
ns/iter (± 34272988
)0.86
small_benches_wall_time/aiamded_breadstick_micro_pack
2206662268
ns/iter (± 28992872
)2284793740
ns/iter (± 59136438
)0.97
This comment was automatically generated by workflow using github-action-benchmark.