Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build warnings #101

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix build warnings #101

merged 3 commits into from
Sep 11, 2024

Conversation

limemloh
Copy link
Collaborator

@limemloh limemloh commented Sep 11, 2024

Purpose

Closes #65

Building the project produces a lot of warnings, most are about missing documentation and end up hiding the more important ones.
This PR fixes every warning, but does not include full support for Concordium node v7 API, this was added here instead

Copy link
Member

@DOBEN DOBEN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Types/ReceiveName.cs Outdated Show resolved Hide resolved
Copy link

@Victor-N-Suadicani Victor-N-Suadicani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look alright, just a few comments but nothing blocking.

src/Types/BakerEvent.cs Show resolved Hide resolved
src/Types/BlockHashInput.cs Outdated Show resolved Hide resolved
src/Types/BlockHeight.cs Outdated Show resolved Hide resolved
src/Types/CcdAmount.cs Outdated Show resolved Hide resolved
src/Types/DelegationEvent.cs Show resolved Hide resolved
src/Types/UpdatePayload.cs Show resolved Hide resolved
@limemloh limemloh merged commit 2f5a904 into main Sep 11, 2024
2 checks passed
@limemloh limemloh deleted the fix-warnings branch September 11, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove documentation build warnings
3 participants