Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made to lower invariant and fixed minor bugs after gRPC update #56

Merged
6 commits merged into from
Jul 27, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jul 25, 2023

Purpose

Made sure all call which creates Hex string make them to lower invariants.

This since from gRPC v1 we have from the nodes returned hex strings in lower invariants. Hence if some have stored these references in some storage and selecting using case sensitive queries, then their logic will be broken.

Changelog not updated since all changes in this PR only affects code which hasn’t been released yet.

Changes

Make Hex strings consistent with earlier protocol.

Also fix minor bugs after gRPC update.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • [-] (If necessary) I have updated the CHANGELOG.

@ghost ghost requested a review from bisgardo July 25, 2023 13:56
@ghost ghost mentioned this pull request Jul 25, 2023
Copy link

@bisgardo bisgardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally all the changes should have been covered by unit tests.

src/Types/BakerInfo.cs Outdated Show resolved Hide resolved
@ghost ghost merged commit b9d4002 into main Jul 27, 2023
1 check passed
@ghost ghost deleted the ss/fix-issues-after-grpc-update branch July 27, 2023 11:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant