Change InteropBindingException to public #86
Conversation
ghost
requested a review
from 
| @@ -5,7 +5,7 @@ namespace Concordium.Sdk.Exceptions; | |||
| /// <summary> | |||
| /// Thrown when a interop call failed with possible error as message. | |||
| /// </summary> | |||
| internal sealed class InteropBindingException : Exception | |||
| public sealed class InteropBindingException : Exception | |||
There was a problem hiding this comment.
I am not a big fan of leaking the internals of the SDK, but if you need this we can merge it
There was a problem hiding this comment.
Why would the users ever want to catch this? What can they do in that case? Is this also used for normal error handling?
I think that a design should rather be talking about user meaningful errors and exceptions, not about the fact that there is some FFI binding somewhere. Users should not need to know that or care about it.
There was a problem hiding this comment.
This is used for the errors returned by the FFI to rust, so they are needed by the user.
I have discussed this with Søren and the plan is now to rename and change this exception to contain an error code (enum matching the rust side error) and the error message provided by rust.
|
Closing in favour of PR #93 |
ghost
closed this
Purpose
Change InteropBindingException such that it can be caught by users.