Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CBW-1440] added support for concordiumwallet://wc deeplink #308

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

TouHouNo
Copy link
Contributor

Changes

added support for new concordiumwallet://wc deeplink

for testing please push an intent with the command adb shell am start -W -a android.intent.action.VIEW -d "concordiumwallet://wc" software.concordium.mobilewallet.seedphrase.testnet

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@TouHouNo TouHouNo requested a review from orhoj October 26, 2023 08:43
@TouHouNo TouHouNo self-assigned this Oct 26, 2023
@github-actions
Copy link

File Coverage [0%]
ScanQRViewModel.kt 0%
MainActivity.kt 0%
Total Project Coverage 0.93%

@github-actions
Copy link

File Coverage [0%]
ScanQRViewModel.kt 0%
MainActivity.kt 0%
Total Project Coverage 0.93%

@TouHouNo TouHouNo requested a review from orhoj October 30, 2023 13:21
@github-actions
Copy link

File Coverage [0%]
MainActivity.kt 0%
Total Project Coverage 0.93%

@orhoj
Copy link
Contributor

orhoj commented Oct 31, 2023

Will wait to approve until Shashi has tested.

Copy link

File Coverage [0%]
MainActivity.kt 0%
Total Project Coverage 0.92%

@TouHouNo TouHouNo merged commit e5fad79 into main Nov 14, 2023
1 check passed
@TouHouNo TouHouNo deleted the feature/CBW-1440-new-deeplink branch November 14, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants