Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling from FFI errors #180

Merged
3 commits merged into from
Feb 5, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 30, 2024

Purpose

The CCD scan currently uses string comparison to handle errors from FFI calls. Due to PR Concordium/concordium-net-sdk#93 on the .NET SDK it is now possible to match on exact error codes.

Task: https://concordium.atlassian.net/browse/CBW-1662

Changes

  • Update handling of errors from FFI calls to use error codes

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@ghost ghost requested review from limemloh and td202 January 30, 2024 09:38
@ghost ghost merged commit 3eadf9e into main Feb 5, 2024
1 check passed
@ghost ghost deleted the cbw-1662/improve-ffi-error-handling branch February 5, 2024 10:23
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant