Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BG-1 INVOICE NOTE in CII #54

Closed
LRabeDE opened this issue Feb 12, 2018 · 5 comments
Closed

BG-1 INVOICE NOTE in CII #54

LRabeDE opened this issue Feb 12, 2018 · 5 comments
Assignees
Milestone

Comments

@LRabeDE
Copy link

LRabeDE commented Feb 12, 2018

Rules in CII Schematron are for my understanding not correct. With respect to the EN 16931-1 an INVOICE NOTE group might occure 0..n times.

The following structure (attached you will find a complete document) seems to me conform to the syntax binding but leads to a warning during validation ([CII-SR-029] - IncludedNote should exist maximum once):

    <rsm:ExchangedDocument>
        <ram:ID>123456</ram:ID>
        <ram:TypeCode>380</ram:TypeCode>
        <ram:IssueDateTime>
            <udt:DateTimeString format="102">20160621</udt:DateTimeString>
        </ram:IssueDateTime>
        <ram:IncludedNote>
            <ram:Content>Bei Fragen zu Ihrer Rechnung wenden Sie sich bitte an unseren Kundenserivce. Sie erreichen uns per Email: […], Tel.: […] oder Fax: […]</ram:Content>
            <ram:SubjectCode>ADU</ram:SubjectCode>
        </ram:IncludedNote>
        <ram:IncludedNote>
            <ram:Content>Die Lieferung erfolgt aufgrund der AGB […] erhältlich unter […]. Auf Wunsch senden wir sie auch zu.</ram:Content>
            <ram:SubjectCode>ADU</ram:SubjectCode>
        </ram:IncludedNote>
        <ram:IncludedNote>
            <ram:Content>Hinweis gemäß § 33 BDSG: Kundendaten werden gespeichert.</ram:Content>
            <ram:SubjectCode>ADU</ram:SubjectCode>
        </ram:IncludedNote>
        <ram:IncludedNote>
            <ram:Content>Beschädigt eingehende Sendungen bitte sofort beim Spediteur bzw. Paketdienstleister reklamieren. Genehmigte Rücksendungen schicken Sie bitte mit den Unterlagen an: […]</ram:Content>
            <ram:SubjectCode>ADU</ram:SubjectCode>
        </ram:IncludedNote>
    </rsm:ExchangedDocument>

01.02a-INVOICE_uncefact.zip

@phax
Copy link
Collaborator

phax commented Feb 12, 2018

You can easily resolve it like this:

        <ram:IncludedNote>
            <ram:Content>Bei Fragen zu Ihrer Rechnung wenden Sie sich bitte an unseren Kundenserivce. Sie erreichen uns per Email: […], Tel.: […] oder Fax: […]
Die Lieferung erfolgt aufgrund der AGB […] erhältlich unter […]. Auf Wunsch senden wir sie auch zu.
Hinweis gemäß § 33 BDSG: Kundendaten werden gespeichert.
Beschädigt eingehende Sendungen bitte sofort beim Spediteur bzw. Paketdienstleister reklamieren. Genehmigte Rücksendungen schicken Sie bitte mit den Unterlagen an: […]</ram:Content>
            <ram:SubjectCode>ADU</ram:SubjectCode>
        </ram:IncludedNote>

You can use multiline comments :)

@LRabeDE
Copy link
Author

LRabeDE commented Feb 12, 2018

ok, this is a solution but this is not realy adressing the issue; which is, that both EN16931 (semantic data model and syntax binding) and underlaying syntac allows the usage of more than one invoice note (BG-1) which is not possible with the existing validation artefacts.

@phax
Copy link
Collaborator

phax commented Feb 12, 2018

Agree - bug in the rules. BG-1 allows for 0..n IncludedNote elements. And I couldn't find a reference to CII-SR-029 in the specs....

My idea here: remove rule CII-SR-029 - any objections.

@LRabeDE
Copy link
Author

LRabeDE commented Feb 13, 2018

Agreed, but... we should also change the context of CII-SR-030 from Exchanged_Document to Exchanged_Document/IncludedNote

@phax
Copy link
Collaborator

phax commented May 16, 2018

Okay, but both are bugs in the rules only. No changes needed in the Specs.

@phax phax removed the wontfix label May 16, 2018
@phax phax added this to the v1.1 milestone Jun 19, 2018
@phax phax self-assigned this Jun 19, 2018
phax added a commit that referenced this issue Jun 19, 2018
phax added a commit that referenced this issue Jun 19, 2018
@phax phax closed this as completed Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants