Skip to content

Commit

Permalink
deps: upgrade all dependencies (nodejs#306)
Browse files Browse the repository at this point in the history
  • Loading branch information
targos authored and joyeecheung committed Nov 11, 2018
1 parent 092cbe5 commit 1e9daeb
Show file tree
Hide file tree
Showing 10 changed files with 1,235 additions and 2,486 deletions.
2 changes: 1 addition & 1 deletion components/git/metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ function handler(argv) {

const merged = Object.assign({}, argv, parsed, config);
return runPromise(getMetadata(merged, cli)
.then(({status}) => {
.then(({ status }) => {
if (status === false) {
throw new Error(IGNORE);
}
Expand Down
8 changes: 4 additions & 4 deletions lib/ci/ci_result_parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class TestBuild extends Job {
this.builtOn = undefined;
}

setBuildData({result, changeSet, actions, timestamp, builtOn}) {
setBuildData({ result, changeSet, actions, timestamp, builtOn }) {
const params = actions.find(item => typeof item.parameters === 'object');
params.parameters.forEach(pair => {
this.params[pair.name] = pair.value;
Expand Down Expand Up @@ -466,7 +466,7 @@ class FailureAggregator {

output += '### Progress\n\n';
output += todo.map(
({count, reason}) => `- \`${reason}\` (${count})`).join('\n'
({ count, reason }) => `- \`${reason}\` (${count})`).join('\n'
);
return output + '\n';
}
Expand Down Expand Up @@ -510,7 +510,7 @@ class CommitBuild extends TestBuild {
super(cli, request, path, tree);
}

getBuilds({result, subBuilds}) {
getBuilds({ result, subBuilds }) {
if (result === SUCCESS) {
const builds = this.builds = {
failed: [], aborted: [], pending: [], unstable: []
Expand Down Expand Up @@ -566,7 +566,7 @@ class CommitBuild extends TestBuild {
}

cli.startSpinner(`Querying failures of ${path}`);
const promises = builds.failed.map(({jobName, buildNumber, url}) => {
const promises = builds.failed.map(({ jobName, buildNumber, url }) => {
if (jobName.includes('fanned')) {
const cause = this.getCause(data.actions);
const isResumed = cause && cause._class.includes('ResumeCause');
Expand Down
2 changes: 1 addition & 1 deletion lib/cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class CLI {

promptForInput(question) {
return new Promise((resolve, reject) => {
read({prompt: question}, (err, answer) => {
read({ prompt: question }, (err, answer) => {
if (err) {
this.log(`\nCanceled: ${err.message}`);
reject(new Error(IGNORE));
Expand Down
2 changes: 1 addition & 1 deletion lib/pr_checker.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class PRChecker {
cli.ok(`Approvals: ${approved.length}${hint}`);

if (comments) {
for (const {reviewer, review} of approved) {
for (const { reviewer, review } of approved) {
if (review.source === FROM_COMMENT ||
review.source === FROM_REVIEW_COMMENT) {
cli.info(
Expand Down
2 changes: 1 addition & 1 deletion lib/reviews.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ class ReviewAnalyzer {
for (const [ login, review ] of reviewers) {
const reviewer = collaborators.get(login.toLowerCase());
if (review.state === APPROVED) {
result.approved.push({reviewer, review});
result.approved.push({ reviewer, review });
} else if (review.state === CHANGES_REQUESTED) {
result.requestedChanges.push({ reviewer, review });
}
Expand Down
2 changes: 1 addition & 1 deletion lib/team_info.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ function byLogin(a, b) {
return a.login.toLowerCase() > b.login.toLowerCase() ? 1 : -1;
}

function getContact({login, url, name, email}) {
function getContact({ login, url, name, email }) {
if (!name) return `- [@${login}](${url})`;
return `- [@${login}](${url}) - ${name}`;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/wpt/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ class WPTUpdater {
);

this.cli.startSpinner('Updating README ...');
const readme = this.templates('README.md')({map: urlMap});
const readme = this.templates('README.md')({ map: urlMap });
writeFile(readmePath, readme);
this.cli.stopSpinner(`Updated ${readmePath}`);
}
Expand Down
Loading

0 comments on commit 1e9daeb

Please sign in to comment.