Reflect PRs in gnark-crypto: A field element is always in Montgomery …

…form and big.Ints are always non-Mont (#422) * refactor: no non-mont on bls12-377 * refactor: groth16 backend tests pass * refactor: MSM takes Montgomery only - Plonk * fix:`ToBigIntRegular` => `BigInt` * fix: more `ToBigIntRegular` => `BigInt`
Consensys · Dec 20, 2022 · 908eb80 · 908eb80
1 parent 935ab13
commit 908eb80
Show file tree

Hide file tree

Showing 77 changed files with 353 additions and 607 deletions.
diff --git a/constraint/bls12-377/coeff.go b/constraint/bls12-377/coeff.go
diff --git a/constraint/bls12-377/solution.go b/constraint/bls12-377/solution.go
diff --git a/constraint/bls12-381/coeff.go b/constraint/bls12-381/coeff.go
diff --git a/constraint/bls12-381/solution.go b/constraint/bls12-381/solution.go
diff --git a/constraint/bls24-315/coeff.go b/constraint/bls24-315/coeff.go
diff --git a/constraint/bls24-315/solution.go b/constraint/bls24-315/solution.go
diff --git a/constraint/bls24-317/coeff.go b/constraint/bls24-317/coeff.go
diff --git a/constraint/bls24-317/solution.go b/constraint/bls24-317/solution.go
diff --git a/constraint/bn254/coeff.go b/constraint/bn254/coeff.go
diff --git a/constraint/bn254/solution.go b/constraint/bn254/solution.go
diff --git a/constraint/bw6-633/coeff.go b/constraint/bw6-633/coeff.go
diff --git a/constraint/bw6-633/solution.go b/constraint/bw6-633/solution.go
diff --git a/constraint/bw6-761/coeff.go b/constraint/bw6-761/coeff.go
diff --git a/constraint/bw6-761/solution.go b/constraint/bw6-761/solution.go
diff --git a/constraint/tinyfield/coeff.go b/constraint/tinyfield/coeff.go
diff --git a/constraint/tinyfield/solution.go b/constraint/tinyfield/solution.go
diff --git a/examples/rollup/operator.go b/examples/rollup/operator.go
@@ -197,8 +197,8 @@ func (o *Operator) updateState(t Transfer, numTransfer int) error {
 
 	// checks if the amount is correct
 	var bAmount, bBalance big.Int
-	receiverAccount.balance.ToBigIntRegular(&bBalance)
-	t.amount.ToBigIntRegular(&bAmount)
+	receiverAccount.balance.BigInt(&bBalance)
+	t.amount.BigInt(&bAmount)
 	if bAmount.Cmp(&bBalance) == 1 {
 		return ErrAmountTooHigh
 	}

diff --git a/go.mod b/go.mod
@@ -5,7 +5,7 @@ go 1.18
 require (
 	github.com/blang/semver/v4 v4.0.0
 	github.com/consensys/bavard v0.1.13
-	github.com/consensys/gnark-crypto v0.8.1-0.20221205155504-6b860ba21fbd
+	github.com/consensys/gnark-crypto v0.8.1-0.20221220191316-4b7364bddab8
 	github.com/fxamacker/cbor/v2 v2.2.0
 	github.com/google/go-cmp v0.5.8
 	github.com/google/pprof v0.0.0-20220729232143-a41b82acbcb1

diff --git a/go.sum b/go.sum
@@ -4,6 +4,8 @@ github.com/consensys/bavard v0.1.13 h1:oLhMLOFGTLdlda/kma4VOJazblc7IM5y5QPd2A/Yj
 github.com/consensys/bavard v0.1.13/go.mod h1:9ItSMtA/dXMAiL7BG6bqW2m3NdSEObYWoH223nGHukI=
 github.com/consensys/gnark-crypto v0.8.1-0.20221205155504-6b860ba21fbd h1:xpAhzOw3dZvRiQeTWmIO8KemBS5XdBsU+/jLfwibEmc=
 github.com/consensys/gnark-crypto v0.8.1-0.20221205155504-6b860ba21fbd/go.mod h1:CkbdF9hbRidRJYMRzmfX8TMOr95I2pYXRHF18MzRrvA=
+github.com/consensys/gnark-crypto v0.8.1-0.20221220191316-4b7364bddab8 h1:Ij6UQpKx4/Ox6L6qFPk8NhEnTsYCEXlILnh+1Hi1grY=
+github.com/consensys/gnark-crypto v0.8.1-0.20221220191316-4b7364bddab8/go.mod h1:CkbdF9hbRidRJYMRzmfX8TMOr95I2pYXRHF18MzRrvA=
 github.com/coreos/go-systemd/v22 v22.3.2/go.mod h1:Y58oyj3AT4RCenI/lSvhwexgC+NSVTIJ3seZv2GcEnc=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=

diff --git a/internal/backend/bls12-377/groth16/prove.go b/internal/backend/bls12-377/groth16/prove.go
diff --git a/internal/backend/bls12-377/groth16/setup.go b/internal/backend/bls12-377/groth16/setup.go
diff --git a/internal/backend/bls12-377/groth16/verify.go b/internal/backend/bls12-377/groth16/verify.go
diff --git a/internal/backend/bls12-377/plonk/prove.go b/internal/backend/bls12-377/plonk/prove.go
diff --git a/internal/backend/bls12-377/plonk/verify.go b/internal/backend/bls12-377/plonk/verify.go