Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use G1 generator from SRS #1035

Merged
merged 1 commit into from
Feb 5, 2024
Merged

fix: use G1 generator from SRS #1035

merged 1 commit into from
Feb 5, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Feb 5, 2024

Description

In #949 we optimized in KZG folding to use curve basepoint to evaluate foldedEval, but KZG SRS G1 generator may be different. This PR reverts the change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Tests work downstream in Linea prover.

How has this been benchmarked?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added the bug Something isn't working label Feb 5, 2024
@ivokub ivokub added this to the v0.10.0 milestone Feb 5, 2024
@ivokub ivokub self-assigned this Feb 5, 2024
@ivokub ivokub merged commit e043c9f into master Feb 5, 2024
7 checks passed
@ivokub ivokub deleted the fix/nonstandard-KZG-g1 branch February 5, 2024 22:05
@ivokub ivokub mentioned this pull request Feb 5, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants