Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove todos #1111

Merged
merged 1 commit into from
Apr 30, 2024
Merged

refactor: remove todos #1111

merged 1 commit into from
Apr 30, 2024

Conversation

yelhousni
Copy link
Contributor

Description

Remove todos. These are future optimizations for cases that are never used but only present as a fallback.

How has this been tested?

N/A

How has this been benchmarked?

N/A

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@yelhousni yelhousni requested a review from gbotrel April 23, 2024 21:25
@yelhousni yelhousni changed the title refactor: removes todods refactor: removes todos Apr 23, 2024
@yelhousni yelhousni changed the title refactor: removes todos refactor: remove todos Apr 23, 2024
@gbotrel gbotrel merged commit 88712e5 into master Apr 30, 2024
7 checks passed
@gbotrel gbotrel deleted the Refac/youssef-todos branch April 30, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants