Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: std/algebra #526

Merged
merged 15 commits into from
Mar 8, 2023
Merged

Refactor: std/algebra #526

merged 15 commits into from
Mar 8, 2023

Conversation

yelhousni
Copy link
Contributor

refactors algebra into native that uses (2-chains) and emulated

@yelhousni yelhousni requested review from ivokub and gbotrel March 6, 2023 16:17
@yelhousni
Copy link
Contributor Author

yelhousni commented Mar 6, 2023 •
edited
Loading

todo:

  • add tests for fields_bn254

@yelhousni yelhousni marked this pull request as draft March 6, 2023 16:30
@yelhousni yelhousni marked this pull request as ready for review March 6, 2023 19:47
@gbotrel
Copy link
Collaborator

gbotrel commented Mar 6, 2023 •
edited by yelhousni
Loading

👍

  • maybe:
  • add a doc.go in std/algebra & emulated / native to brievely introduce differences between these pacakges

@yelhousni
Copy link
Contributor Author

todo:

  • add tests for fields_bn254

@ivokub @gbotrel Done in #532 but in a separate PR as I'm doing some refactoring/cleaning there. We can merge this PR.

@yelhousni yelhousni self-assigned this Mar 7, 2023
ivokub
ivokub requested changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Otherwise looks good.

std/algebra/emulated/sw_bn254/pairing.go Show resolved Hide resolved
std/algebra/emulated/sw_bn254/pairing.go Show resolved Hide resolved
std/algebra/emulated/sw_bn254/pairing.go Show resolved Hide resolved
std/algebra/emulated/sw_bn254/pairing_test.go Outdated Show resolved Hide resolved
std/algebra/emulated/sw_bn254/pairing_test.go Outdated Show resolved Hide resolved
std/algebra/emulated/fields_bn254/e12_pairing.go Outdated Show resolved Hide resolved
std/algebra/emulated/fields_bn254/doc.go Show resolved Hide resolved
std/algebra/native/fields_bls12377/doc.go Show resolved Hide resolved
@yelhousni yelhousni requested a review from ivokub March 7, 2023 15:04
ivokub
ivokub approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbotrel gbotrel merged commit 8ed586e into develop Mar 8, 2023
@gbotrel gbotrel deleted the refactor/std/algebra branch March 8, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

@gbotrel gbotrel Awaiting requested review from gbotrel

Assignees

@yelhousni yelhousni

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yelhousni @gbotrel @ivokub