Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish tests for all curves #8

Merged
merged 8 commits into from
Mar 3, 2020
Merged

Finish tests for all curves #8

merged 8 commits into from
Mar 3, 2020

Conversation

ggutoski
Copy link
Contributor

@ggutoski ggutoski commented Mar 3, 2020

  • Many tests were missing for the curve subgroups G1, G2 on bls381, bn256---especially test points for multiexp.
  • This PR restores all tests for all curves. I had to manually compute many test points using sagemath.
  • Tests for G1, G2 are now automatically generated via go generate in the appropriate curve directory (bls377, bls381, bn256).
  • Previously some codegen was commented out of the code generator. This PR restores all commented out codegen except for the pairing code. The commented out pairing code inside codegen is just a stub. It was never used to generate pairing code and lots needs to be done in order to bring all pairing code for all curves inside codegen. I'm leaving that for future work.

@ggutoski ggutoski requested a review from gbotrel March 3, 2020 06:57
@gbotrel gbotrel merged commit d321572 into develop Mar 3, 2020
@gbotrel gbotrel deleted the internal-curve-tests branch March 3, 2020 15:14
ruslangm pushed a commit to ruslangm/gnark that referenced this pull request Dec 29, 2022
@ZhAnGeek @yycen @lightning-li
Zkbnb dev mem branch fix (Consensys#8)
5d28e94 
* Add memory expanding feature

* Add session id to dump files

* Use correct size of lazyCons

* add interface for groth16 setup

* fix: constant values

* fix: constants different types

* Add zkbnb circuit example

* Fix restore pkB2 in proveRoll

* Add some utility functions

* fix: poseidon initial coeffs incorrect

* add function for app use

* ADD: batch verification and api modification

* fix: add less than implementation directly

* add r1cs load funcation

* Add unmarshalcbor option in hint dec

* correct constraints counts

* fix: change constants to variable when meet

* Add lazy circuit verify testcase

* fix: sort linear expression, fix dm test

* Clean up code and add debuginfo switcher

* refactor: integrate gnark-crypto

* Update ENV name to load debugInfo

* fix: go staticcheck lint

* fix: test removal and clean

Co-authored-by: ycen <yycen@live.com>
Co-authored-by: ryan <lightningli0504@gmail.com>
Co-authored-by: ZhAnGeek <lecky.z@nodereal.io>
ThomasPiellard added a commit to ThomasPiellard/gnark that referenced this pull request Jul 9, 2024
@ThomasPiellard
Merge pull request Consensys#8 from ThomasPiellard/audit/L-05
969e97b 
fix: fixed L-05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbotrel gbotrel Awaiting requested review from gbotrel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggutoski @gbotrel