perf: mark the result of builder.IsZero
as boolean to save constraints when used in future
#977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi there, thanks for your amazing work!
In the current implementation of gnark,
builder.Select
introduces a constraint to enforce that the condition is boolean. However, when the condition is from the result ofbuilder.IsZero
, this constraint is unnecessary, asbuilder.IsZero
always returns a valuem
that is guaranteed to be either 0 or 1.This PR marks
m
inbuilder.IsZero
as boolean, so that we can save 1 constraint when using the result in subsequent operations likeSelect
.Type of change
Checklist:
golangci-lint
does not output errors locally