Skip to content

Commit

Permalink
Missing aria labels
Browse files Browse the repository at this point in the history
  • Loading branch information
CookedIdeas committed Oct 27, 2023
1 parent f79118a commit c5d24e1
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ You can use default title and description or set custom page title and descripti

Use site meta data with custom hook useSiteMetaData.

og:image setting : When sharing mebsite link to social media, an image is added (used image is og-image.png in 1_Components/1_Seo_Head).
Social media sharing : og:image is set with a custom illustration (used image is og-image.png in 1_Components/1_Seo_Head).

<p align="center">
<img src="git-assets/ogimage.png" alt="og-image" width="50%" height="auto">
Expand Down
10 changes: 7 additions & 3 deletions src/1_components/2_Layout/Navbar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,15 @@ const Navbar = () => {
return (
<header className="navbar bg-base-300 px-2 sm:px-5 md:px-10">
<div className="navbar-start">
<Link to="/" className="btn btn-ghost">
<Link to="/" className="btn btn-ghost" aria-label="back to home page">
<LogoForNavbar />
</Link>
<div className="dropdown">
<button tabIndex={0} className="btn btn-ghost md:hidden">
<button
tabIndex={0}
className="btn btn-ghost md:hidden"
aria-label="toggle nav links menu"
>
<GiHamburgerMenu className="h-6 w-6" />
</button>
<button
Expand Down Expand Up @@ -83,7 +87,7 @@ const Navbar = () => {
</div>
<div className="navbar-end pr-6">
{/* THEME ICONS */}
<label className="swap swap-flip ">
<label className="swap swap-flip" aria-label="toggle theme">
<input type="checkbox" onChange={handleTheme} />
<BsSunFill className="swap-on h-4 w-4 " />
<BsFillMoonFill className="swap-off h-4 w-4" />
Expand Down

0 comments on commit c5d24e1

Please sign in to comment.