Skip to content

Commit

Permalink
Introduce module to verify all Oban.insert clauses
Browse files Browse the repository at this point in the history
The recent addition of a @SPEC for `Oban.insert/2` broke dialyzer in
some situations. To prevent this regression in the future we now include
a compiled module that exercises all `Oban.insert` variations.

Closes oban-bg#762
  • Loading branch information
sorentwo committed Aug 29, 2022
1 parent cba6e00 commit 823bc61
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
2 changes: 0 additions & 2 deletions lib/oban.ex
Original file line number Diff line number Diff line change
Expand Up @@ -241,8 +241,6 @@ defmodule Oban do
def config(name \\ __MODULE__), do: Registry.config(name)

@doc false
@spec insert(Job.changeset(), Keyword.t()) ::
{:ok, Job.t()} | {:error, Job.changeset() | term()}
def insert(%Changeset{} = changeset, opts) do
insert(__MODULE__, changeset, opts)
end
Expand Down
22 changes: 22 additions & 0 deletions test/support/exercise.ex
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
defmodule Oban.Test.Exercise do
@moduledoc false

alias Ecto.Multi
alias Oban.Job

def check_install do
changeset = changeset()

{:ok, _} = Oban.insert(changeset)
{:ok, _} = Oban.insert(Oban, changeset)
{:ok, _} = Oban.insert(changeset, timeout: 500)
{:ok, _} = Oban.insert(Oban, changeset, timeout: 500)

%Multi{} = Oban.insert(Multi.new(), :job, changeset)
%Multi{} = Oban.insert(Multi.new(), :job, changeset, timeout: 500)
%Multi{} = Oban.insert(Oban, Multi.new(), :job, changeset)
%Multi{} = Oban.insert(Oban, Multi.new(), :job, changeset, timeout: 500)
end

defp changeset, do: Job.new(%{}, worker: "FakeWorker")
end

0 comments on commit 823bc61

Please sign in to comment.